Merge pull request bitcoin-dev-project#406 from bitcoin-dev-project/return-code-scenarios

Add return code on scenarios

Author: m3dwards

src/warnet/server.py

@@ -412,6 +412,7 @@ def scenarios_list_running(self) -> list[dict]:
                 "pid": sc["pid"],
                 "cmd": sc["cmd"],
                 "active": sc["proc"].poll() is None,
+                "return_code": sc["proc"].returncode,
                 "network": sc["network"],
             }
             for sc in self.running_scenarios

test/ln_test.py

@@ -43,6 +43,9 @@ def run_ln_init_scenario(self):
         self.warcli("rpc 0 getblockcount")
         self.warcli("scenarios run ln_init")
         self.wait_for_all_scenarios()
+        scenario_return_code = self.get_scenario_return_code("ln_init")
+        if scenario_return_code != 0:
+            raise Exception("LN Init scenario failed")
 
     def test_channel_policies(self):
         self.log.info("Ensuring node-level channel policy settings")

test/test_base.py

@@ -169,3 +169,10 @@ def check_scenarios():
             return all(not scn["active"] for scn in scns)
 
         self.wait_for_predicate(check_scenarios)
+
+    def get_scenario_return_code(self, scenario_name):
+        scns = self.rpc("scenarios_list_running")
+        scns = [scn for scn in scns if scn["cmd"].strip() == scenario_name]
+        if len(scns) == 0:
+            raise Exception(f"Scenario {scenario_name} not found in running scenarios")
+        return scns[0]["return_code"]