Merge pull request #2 from openculinary/issue-1/empty-attribute-search

willforde · web-flow · commit a90d36d465b9 · 2022-10-21T00:31:52.000+01:00
Support XPath attribute-existence search for empty-valued HTML element attributes
diff --git a/htmlement.py b/htmlement.py
@@ -330,7 +330,7 @@ def _handle_starttag(self, tag, attrs, self_closing=False):
         # Add tag element to tree if we have no filter or that the filter matches
         if enabled or self._search(tag, attrs):
             # Convert attrs to dictionary
-            attrs = dict(attrs) if attrs else {}
+            attrs = {k: v or "" for k, v in attrs}
             self._flush()
 
             # Create the new element
diff --git a/tests/test_module.py b/tests/test_module.py
@@ -129,6 +129,14 @@ def test_extra_tag():
     assert Etree.tostring(root, method="html") == b'<html><body></body></html>'
 
 
+def test_find_empty_attribute():
+    # Check whether we can find an element with an empty-valued attribute
+    html = "<html><body><form autofocus><input type='checkbox' checked></form></body></html>"
+    form = quick_parse_filter(html, "form", {"autofocus": True})
+    assert "autofocus" in form.attrib
+    assert form.find(".//input[@checked]") is not None
+
+
 # ############################# HTML Entity ############################## #
 
 
