update tests a little, add comments to explain

Author: Will Honey

src/util/import-type.ts

@@ -2,7 +2,8 @@ export function isAbsolute(name: string): boolean {
 	return name.indexOf('/') === 0;
 }
 
-const moduleRegExp = /^[^/\\.]/;
+// a module is anything that doesn't start with a . or a / or a \
+const moduleRegExp = /^[^\/\\.]/;
 export function isModule(name: string): boolean {
 	return moduleRegExp.test(name);
 }

test/rules/order-imports-2.js

@@ -8,14 +8,19 @@ const rule = require('rules/order-imports');
 ruleTester.run('order', rule, {
 	valid: [
 		// Default order using import
+		// absolute at top
+		// modules starting with _ or @ are sorted with modules
 		test({
 			code: `
-				import async, {foo1} from 'async';
+				import abs from '/absolute/module';
+
+				import blah from '_lodash';
 				import module from '@module/core';
 				import print from '@module/print';
+				import async, {foo1} from 'async';
 				import fs from 'fs';
 
-		    import relParent1 from '../foo';
+		    	import relParent1 from '../foo';
 				import relParent2, {foo2} from '../foo/bar';
 
 				import relParent3 from '@shared';
@@ -25,11 +30,11 @@ ruleTester.run('order', rule, {
 				import index from './';`,
 			options: [
 				{
-					groups: ['module', 'parent', '/@shared/', 'sibling', 'index'],
+					groups: ['absolute', 'module', 'parent', '/@shared/', 'sibling', 'index'],
 					alphabetize: { order: 'asc', ignoreCase: true },
-					newlinesBetween: 'always'
-				}
-			]
+					newlinesBetween: 'always',
+				},
+			],
 		}),
 		test({
 			code: `
@@ -46,9 +51,9 @@ ruleTester.run('order', rule, {
 				{
 					groups: [['module'], '/@shared/', ['parent', 'sibling', 'index']],
 					alphabetize: { order: 'asc', ignoreCase: true },
-					newlinesBetween: 'always'
-				}
-			]
+					newlinesBetween: 'always',
+				},
+			],
 		}),
 		test({
 			code: `
@@ -67,9 +72,9 @@ ruleTester.run('order', rule, {
 			options: [
 				{
 					groups: ['module', '/^@shared/', 'parent', 'sibling', 'index'],
-					newlinesBetween: 'always'
-				}
-			]
+					newlinesBetween: 'always',
+				},
+			],
 		}),
 		test({
 			code: `
@@ -90,10 +95,10 @@ ruleTester.run('order', rule, {
 				{
 					groups: [['module'], '/@shared/', ['parent', 'sibling', 'index']],
 					alphabetize: { order: 'asc', ignoreCase: true },
-					newlinesBetween: 'always-and-inside-groups'
-				}
-			]
-		})
+					newlinesBetween: 'always-and-inside-groups',
+				},
+			],
+		}),
 	],
 	invalid: [
 		// Option alphabetize: {order: 'desc', ignoreCase: true}
@@ -113,15 +118,15 @@ ruleTester.run('order', rule, {
 			options: [
 				{
 					groups: ['module', 'index'],
-					alphabetize: { order: 'desc', ignoreCase: true }
-				}
+					alphabetize: { order: 'desc', ignoreCase: true },
+				},
 			],
 			errors: [
 				{
 					ruleID: 'order',
-					message: '`Baz` import should occur before import of `bar`'
-				}
-			]
-		})
-	]
+					message: '`Baz` import should occur before import of `bar`',
+				},
+			],
+		}),
+	],
 });