From e6bf85b816ad4f918c1b622c60dd51e0fbeb697c Mon Sep 17 00:00:00 2001 From: Natechawin Suthison Date: Sat, 4 Apr 2020 01:50:51 +0700 Subject: [PATCH] Remove unnecessary variable assignment Since Java uses pass by value even if the object is a reference type, so when you set node = null here is gonna effect only in the local scope. --- .../datastructures/binarysearchtree/BinarySearchTree.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/com/williamfiset/datastructures/binarysearchtree/BinarySearchTree.java b/com/williamfiset/datastructures/binarysearchtree/BinarySearchTree.java index 48e1518..1374be3 100644 --- a/com/williamfiset/datastructures/binarysearchtree/BinarySearchTree.java +++ b/com/williamfiset/datastructures/binarysearchtree/BinarySearchTree.java @@ -116,7 +116,6 @@ private Node remove(Node node, T elem) { Node rightChild = node.right; node.data = null; - node = null; return rightChild; @@ -128,7 +127,6 @@ private Node remove(Node node, T elem) { Node leftChild = node.left; node.data = null; - node = null; return leftChild;