black

Author: williballenthin

idb/__init__.py

@@ -15,7 +15,6 @@ def memview(buf):
         #     bytes(memoryview('foo')) == "<memoryview ...>"
         return buf
 
-
 else:
 
     def memview(buf):

idb/analysis.py

@@ -258,9 +258,7 @@ def __init__(self, db, nodeid, fields):
         # note that order of fields is important:
         #   fields with matching minvers override previously defined fields of the same name
         self._fields_by_name = {
-            f.name: f
-            for f in self.fields
-            if (not f.minver) or (f.minver and idb_version >= f.minver)
+            f.name: f for f in self.fields if (not f.minver) or (f.minver and idb_version >= f.minver)
         }
 
     def _is_address(self, index):
@@ -457,9 +455,7 @@ def u32_(self):
         if val == 0xFF:
             val = self.u32(big=True)
         elif val & 0xC0 == 0xC0:
-            val = (
-                ((val & 0x1F) << 24) | (self.u8() << 16) | (self.u8() << 8) | self.u8()
-            )
+            val = ((val & 0x1F) << 24) | (self.u8() << 16) | (self.u8() << 8) | self.u8()
         elif val & 0x80:
             val = ((val & 0x3F) << 8) | self.u8()
         return val
@@ -1174,9 +1170,7 @@ def pairs(l):
 
 Chunk = namedtuple("Chunk", ["effective_address", "length"])
 FunctionParameter = namedtuple("FunctionParameter", ["type", "name"])
-FunctionSignature = namedtuple(
-    "FunctionSignature", ["calling_convention", "rtype", "unk", "parameters"]
-)
+FunctionSignature = namedtuple("FunctionSignature", ["calling_convention", "rtype", "unk", "parameters"])
 StackChangePoint = namedtuple("StackChangePoint", ["effective_address", "change"])
 
 
@@ -1226,9 +1220,7 @@ def get_signature(self):
             typedata.deserialize(self.idb.til, ts, names, [])
             inf = Root(self.idb).idainfo
 
-            return idb.typeinf.TInfo(
-                typ, typedata, til=self.idb.til, name=self.get_name(), inf=inf
-            )
+            return idb.typeinf.TInfo(typ, typedata, til=self.idb.til, name=self.get_name(), inf=inf)
         except KeyError:
             return None
 
@@ -1283,7 +1275,7 @@ def get_stack_change_points(self):
             unpacker = unpack_dqs
         else:
             raise RuntimeError("unexpected wordsize")
-        for (delta, change) in pairs(unpacker(v)):
+        for delta, change in pairs(unpacker(v)):
             offset += delta
             if change & 1:
                 change = change >> 1
@@ -1575,9 +1567,7 @@ def enumerate_imports(db):
     ],
 )
 
-EntryPoint = namedtuple(
-    "EntryPoint", ["name", "address", "ordinal", "forwarded_symbol"]
-)
+EntryPoint = namedtuple("EntryPoint", ["name", "address", "ordinal", "forwarded_symbol"])
 
 
 def enumerate_entrypoints(db):
@@ -1597,14 +1587,10 @@ def enumerate_entrypoints(db):
     for index, addr in ents.functions.items():
         if index == db.uint(-1):
             break
-        yield EntryPoint(
-            names.get(index), addr, ordinals.get(index), forwarded_symbols.get(index)
-        )
+        yield EntryPoint(names.get(index), addr, ordinals.get(index), forwarded_symbols.get(index))
 
     for index, addr in ents.main_entry.items():
-        yield EntryPoint(
-            names.get(index), addr, ordinals.get(index), forwarded_symbols.get(index)
-        )
+        yield EntryPoint(names.get(index), addr, ordinals.get(index), forwarded_symbols.get(index))
 
 
 ScriptSnippets = Analysis(

idb/fileformat.py

@@ -1,6 +1,7 @@
 """
 lots of inspiration from: https://github.com/nlitsme/pyidbutil
 """
+
 import re
 import abc
 import zlib
@@ -762,9 +763,7 @@ def prev(self):
             next_page = self.index.get_page(next_page_number)
             while not next_page.is_leaf():
                 self.path.append(next_page)
-                next_page = self.index.get_page(
-                    next_page.get_entry(next_page.entry_count - 1).page
-                )
+                next_page = self.index.get_page(next_page.get_entry(next_page.entry_count - 1).page)
 
             self.path.append(next_page)
             self.entry = next_page.get_entry(next_page.entry_count - 1)
@@ -962,9 +961,7 @@ def pcb__segments(self):
         for i in range(self.segment_count):
             segment = self._segments[i]
             segment_byte_count = segment.end - segment.start
-            segment_length = (
-                4 * segment_byte_count
-            )  # each flag entry is a uint32 on all platforms
+            segment_length = 4 * segment_byte_count  # each flag entry is a uint32 on all platforms
             self.segments.append(ID1.SegmentDescriptor(segment, offset))
             offset += segment_length
         offset = 0x14 + (self.segment_count * (2 * self.wordsize))

idb/idapython.py

@@ -644,9 +644,7 @@ class idc:
     SEGPERM_READ = 4  # Read
     SEGPERM_MAXVAL = 7  # (SEGPERM_EXEC + SEGPERM_WRITE + SEGPERM_READ)
 
-    SFL_COMORG = (
-        0x01  # IDP dependent field (IBM PC: if set, ORG directive is not commented out)
-    )
+    SFL_COMORG = 0x01  # IDP dependent field (IBM PC: if set, ORG directive is not commented out)
     SFL_OBOK = 0x02  # orgbase is present? (IDP dependent field)
     SFL_HIDDEN = 0x04  # is the segment hidden?
     SFL_DEBUG = 0x08  # is the segment created for the debugger?
@@ -844,9 +842,7 @@ def GetSegmentAttr(self, ea, attr):
         elif attr == self.SEGATTR_COLOR:
             return self._get_segment(ea).color
         else:
-            raise NotImplementedError(
-                "segment attribute %d not yet implemented" % (attr)
-            )
+            raise NotImplementedError("segment attribute %d not yet implemented" % (attr))
 
     def MinEA(self):
         segs = idb.analysis.Segments(self.idb).segments.values()
@@ -885,9 +881,7 @@ def ItemSize(self, ea):
     def NextHead(self, ea):
         ea += 1
         flags = self.GetFlags(ea)
-        while (
-            flags is not None and flags != 0 and not self.api.ida_bytes.is_head(flags)
-        ):
+        while flags is not None and flags != 0 and not self.api.ida_bytes.is_head(flags):
             ea += 1
             # TODO: handle Index/KeyError here when we overrun a segment
             flags = self.GetFlags(ea)
@@ -1030,20 +1024,13 @@ def _disassemble(self, ea):
                 )
         elif procname == "sparcb":
             if bitness == 32:
-                dis = self._load_dis(
-                    capstone.CS_ARCH_SPARC, capstone.CS_MODE_BIG_ENDIAN
-                )
+                dis = self._load_dis(capstone.CS_ARCH_SPARC, capstone.CS_MODE_BIG_ENDIAN)
         elif procname == "sparcl":
             if bitness == 32:
-                dis = self._load_dis(
-                    capstone.CS_ARCH_SPARC, capstone.CS_MODE_LITTLE_ENDIAN
-                )
+                dis = self._load_dis(capstone.CS_ARCH_SPARC, capstone.CS_MODE_LITTLE_ENDIAN)
 
         if dis is None:
-            raise NotImplementedError(
-                "unknown arch %s bit:%s inst_len:%d"
-                % (procname, bitness, len(inst_buf))
-            )
+            raise NotImplementedError("unknown arch %s bit:%s inst_len:%d" % (procname, bitness, len(inst_buf)))
         dis.detail = True
 
         try:
@@ -1294,22 +1281,12 @@ def isCustFmt1(flags):
     @staticmethod
     def isNum0(flags):
         t = flags & FLAGS.MS_0TYPE
-        return (
-            t == FLAGS.FF_0NUMB
-            or t == FLAGS.FF_0NUMO
-            or t == FLAGS.FF_0NUMD
-            or t == FLAGS.FF_0NUMH
-        )
+        return t == FLAGS.FF_0NUMB or t == FLAGS.FF_0NUMO or t == FLAGS.FF_0NUMD or t == FLAGS.FF_0NUMH
 
     @staticmethod
     def isNum1(flags):
         t = flags & FLAGS.MS_1TYPE
-        return (
-            t == FLAGS.FF_1NUMB
-            or t == FLAGS.FF_1NUMO
-            or t == FLAGS.FF_1NUMD
-            or t == FLAGS.FF_1NUMH
-        )
+        return t == FLAGS.FF_1NUMB or t == FLAGS.FF_1NUMO or t == FLAGS.FF_1NUMD or t == FLAGS.FF_1NUMH
 
     @staticmethod
     def get_optype_flags0(flags):
@@ -1529,11 +1506,7 @@ def next_inited(self, ea, maxea):
     def get_item_end(self, ea):
         ea += 1
         flags = self.api.idc.GetFlags(ea)
-        while (
-            flags is not None
-            and not self.api.ida_bytes.is_head(flags)
-            and self.api.idc.SegEnd(ea)
-        ):
+        while flags is not None and not self.api.ida_bytes.is_head(flags) and self.api.idc.SegEnd(ea):
             ea += 1
             flags = self.api.idc.GetFlags(ea)
         return ea
@@ -1919,11 +1892,7 @@ def _find_bb_end(self, ea):
         Returns:
           int: the address of the final instruction in the basic block. it may be the same as the start.
         """
-        if not is_empty(
-            idb.analysis.get_crefs_from(
-                self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F]
-            )
-        ):
+        if not is_empty(idb.analysis.get_crefs_from(self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F])):
             return ea
 
         if not self.api.idc.GetFlags(ea):
@@ -1946,11 +1915,7 @@ def _find_bb_end(self, ea):
             if not self.api.ida_bytes.is_flow(flags):
                 return last_ea
 
-            if not is_empty(
-                idb.analysis.get_crefs_from(
-                    self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F]
-                )
-            ):
+            if not is_empty(idb.analysis.get_crefs_from(self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F])):
                 return ea
 
     def _find_bb_start(self, ea):
@@ -1972,11 +1937,7 @@ def _find_bb_start(self, ea):
             last_ea = ea
             ea = self.api.idc.PrevHead(ea)
 
-            if not is_empty(
-                idb.analysis.get_crefs_from(
-                    self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F]
-                )
-            ):
+            if not is_empty(idb.analysis.get_crefs_from(self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F])):
                 return last_ea
 
             if not self.api.ida_bytes.is_flow(flags):
@@ -1993,9 +1954,7 @@ def _get_flow_preds(self, ea):
 
         # get all the flow xrefs to this instruction.
         # a flow xref is like a fallthrough or jump, not like a call.
-        for xref in idb.analysis.get_crefs_to(
-            self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F]
-        ):
+        for xref in idb.analysis.get_crefs_to(self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F]):
             yield xref
 
     def _get_flow_succs(self, ea):
@@ -2010,9 +1969,7 @@ def _get_flow_succs(self, ea):
 
         # get all the flow xrefs from this instruction.
         # a flow xref is like a fallthrough or jump, not like a call.
-        for xref in idb.analysis.get_crefs_from(
-            self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F]
-        ):
+        for xref in idb.analysis.get_crefs_from(self.idb, ea, types=[idaapi.fl_JN, idaapi.fl_JF, idaapi.fl_F]):
             yield xref
 
     def FlowChart(self, func):
@@ -2083,9 +2040,7 @@ def __init__(self, db, api, ea):
                     for xref in api.idaapi._get_flow_preds(block.startEA):
                         if xref.frm not in bbs_by_end:
                             pred_start = api.idaapi._find_bb_start(xref.frm)
-                            pred = BasicBlock(
-                                self, pred_start, xref.frm, api.idc.NextHead(xref.frm)
-                            )
+                            pred = BasicBlock(self, pred_start, xref.frm, api.idc.NextHead(xref.frm))
                             bbs_by_start[pred.startEA] = pred
                             bbs_by_end[pred.lastInstEA] = pred
                         else:
@@ -2100,9 +2055,7 @@ def __init__(self, db, api, ea):
                     for xref in api.idaapi._get_flow_succs(block.lastInstEA):
                         if xref.to not in bbs_by_start:
                             succ_end = api.idaapi._find_bb_end(xref.to)
-                            succ = BasicBlock(
-                                self, xref.to, succ_end, api.idc.NextHead(succ_end)
-                            )
+                            succ = BasicBlock(self, xref.to, succ_end, api.idc.NextHead(succ_end))
                             bbs_by_start[succ.startEA] = succ
                             bbs_by_end[succ.lastInstEA] = succ
                         else:
@@ -2541,9 +2494,7 @@ def DataRefsFrom(self, ea):
 
         # calls are not data references.
         # global variables are data references.
-        for xref in idb.analysis.get_drefs_from(
-            self.idb, ea, types=self.ALL_DREF_TYPES
-        ):
+        for xref in idb.analysis.get_drefs_from(self.idb, ea, types=self.ALL_DREF_TYPES):
             yield xref.to
 
     def DataRefsTo(self, ea):
@@ -2806,9 +2757,7 @@ def get_first_struc_idx(self):
         return 0 if len(self._struct_ids) > 0 else self.api.idc.BADADDR
 
     def get_last_struc_idx(self):
-        return (
-            self._struct_ids[-1] if len(self._struct_ids) > 0 else self.api.idc.BADADDR
-        )
+        return self._struct_ids[-1] if len(self._struct_ids) > 0 else self.api.idc.BADADDR
 
     def get_struc(self, id):
         """Get pointer to struct type info."""
@@ -2859,9 +2808,7 @@ def get_ordinal_from_idb_type(self, name, _type):
         if not _type or len(_type) == 0:
             return -1
         typ = self.get_named_type(name)
-        if self.get_base_flags(typ.type.base_type) == self.get_base_flags(
-            ord(_type[0])
-        ):
+        if self.get_base_flags(typ.type.base_type) == self.get_base_flags(ord(_type[0])):
             return typ.ordinal
         else:
             return -1

idb/netnode.py

@@ -92,13 +92,9 @@ def make_key(nodeid, tag=None, index=None, wordsize=4):
         if index is None:
             return b"." + struct.pack(">" + wordformat + "c", nodeid, tag)
         elif index < 0:
-            return b"." + struct.pack(
-                ">" + wordformat + "c" + wordformat.lower(), nodeid, tag, index
-            )
+            return b"." + struct.pack(">" + wordformat + "c" + wordformat.lower(), nodeid, tag, index)
         else:
-            return b"." + struct.pack(
-                ">" + wordformat + "c" + wordformat, nodeid, tag, index
-            )
+            return b"." + struct.pack(">" + wordformat + "c" + wordformat, nodeid, tag, index)
     else:
         raise ValueError("unexpected type of nodeid: " + str(type(nodeid)))
 

idb/shim.py

@@ -41,7 +41,6 @@ def load_module(self, fullname):
         def install(self):
             sys.meta_path.insert(0, self)
 
-
 elif sys.version_info[0] == 3:
     import sys
     import types