More code review

Author: DerEchtePilz

commandapi-platforms/commandapi-bukkit/commandapi-bukkit-plugin-common/src/main/java/dev/jorel/commandapi/config/BukkitConfigurationAdapter.java

@@ -5,6 +5,7 @@
 import org.bukkit.configuration.file.YamlConfiguration;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashSet;
@@ -112,12 +113,15 @@ public ConfigurationAdapter<YamlConfiguration> createNew() {
 	public void saveDefaultConfig(File directory, File configFile, Logger logger) {
 		ConfigGenerator configGenerator = ConfigGenerator.createNew(DefaultBukkitConfig.createDefault());
 		if (!directory.exists()) {
-			directory.mkdir();
+			boolean createdDirectory = directory.mkdirs();
+			if (!createdDirectory) {
+				logger.severe("Failed to create directory for the CommandAPI's config.yml file!");
+			}
 			try {
 				ConfigurationAdapter<YamlConfiguration> bukkitConfigurationAdapter = new BukkitConfigurationAdapter(new YamlConfiguration());
 				configGenerator.populateDefaultConfig(bukkitConfigurationAdapter);
 				bukkitConfigurationAdapter.config().save(configFile);
-			} catch (Exception e) {
+			} catch (IOException e) {
 				logger.severe("Could not create default config file! This is (probably) a bug.");
 				logger.severe("Error message: " + e.getMessage());
 				logger.severe("Stacktrace:");
@@ -136,7 +140,7 @@ public void saveDefaultConfig(File directory, File configFile, Logger logger) {
 				return;
 			}
 			updatedConfig.config().save(configFile);
-		} catch (Exception e) {
+		} catch (IOException e) {
 			logger.severe("Could not update config! This is (probably) a bug.");
 			logger.severe("Error message: " + e.getMessage());
 			logger.severe("Stacktrace:");

commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/CommandAPIMain.java

@@ -36,7 +36,7 @@ public CommandAPIMain(ProxyServer server, Logger logger, @DataDirectory Path dat
 		Path configFile = dataDirectory.resolve("config.yml");
 
 		// Create or update config
-		VelocityConfigurationAdapter.createDummyInstance().saveDefaultConfig(configFile.getParent().toFile(), configFile.toFile(), null);
+		VelocityConfigurationAdapter.createDummyInstance().saveDefaultConfig(configFile.getParent().toFile(), configFile.toFile(), logger);
 
 		// Load the file as a yaml node
 		ConfigurationNode configYAML;

commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/config/VelocityConfigurationAdapter.java

@@ -97,14 +97,21 @@ public void saveDefaultConfig(File directory, File configFile, Logger logger) {
 		DefaultVelocityConfig defaultConfig = DefaultVelocityConfig.createDefault();
 		ConfigGenerator configGenerator = ConfigGenerator.createNew(defaultConfig);
 		if (!directory.exists()) {
-			directory.mkdirs();
-
+			boolean createdDirectory = directory.mkdirs();
+			if (!createdDirectory) {
+				logger.severe("Failed to create directory for the CommandAPI's config.yml file!");
+			}
 			try {
 				ConfigurationAdapter<ConfigurationNode> velocityConfigurationAdapter = new VelocityConfigurationAdapter(configLoader, configLoader.createNode(), defaultConfig);
 				configGenerator.populateDefaultConfig(velocityConfigurationAdapter);
 				configLoader.save(velocityConfigurationAdapter.config());
 			} catch (IOException e) {
-				throw new RuntimeException(e);
+				logger.severe("Could not create default config file! This is (probably) a bug.");
+				logger.severe("Error message: " + e.getMessage());
+				logger.severe("Stacktrace:");
+				for (StackTraceElement element : e.getStackTrace()) {
+					logger.severe(element.toString());
+				}
 			}
 		} else {
 			try {
@@ -116,7 +123,12 @@ public void saveDefaultConfig(File directory, File configFile, Logger logger) {
 					configLoader.save(updatedConfig.config());
 				}
 			} catch (IOException e) {
-				throw new RuntimeException(e);
+				logger.severe("Could not update config! This is (probably) a bug.");
+				logger.severe("Error message: " + e.getMessage());
+				logger.severe("Stacktrace:");
+				for (StackTraceElement element : e.getStackTrace()) {
+					logger.severe(element.toString());
+				}
 			}
 		}
 	}