Skip to content

Commit 5a75af8

Browse files
committed
Add all versions to GitHub Actions tests
Add testAllVersions.sh for locally running all maven tests
1 parent 3ed0e0e commit 5a75af8

File tree

3 files changed

+57
-3
lines changed

3 files changed

+57
-3
lines changed

.github/workflows/build.yml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,14 @@ jobs:
9191
# Dev note: Yes, I know I could put this under one run section, but it's a million times easier
9292
# to see which version failed when it's got the version name and subsection in GitHub Actions
9393

94+
- name: Run Bukkit unit tests across all versions (1.20.5 - 1.20.6)
95+
continue-on-error: true
96+
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_20_5
97+
98+
- name: Run Bukkit unit tests across all versions (Mojang Mapped 1.20.5 - 1.20.6)
99+
continue-on-error: true
100+
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_20_5_Mojang
101+
94102
- name: Run Bukkit unit tests across all versions (1.20.3 - 1.20.4)
95103
continue-on-error: true
96104
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_20_3
@@ -99,14 +107,22 @@ jobs:
99107
continue-on-error: true
100108
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_20_2
101109

102-
- name: Run Bukkit unit tests across all versions (1.20)
110+
- name: Run Bukkit unit tests across all versions (1.20 - 1.20.1)
103111
continue-on-error: true
104112
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_20
105113

114+
- name: Run Bukkit unit tests across all versions (Mojang Mapped 1.20 - 1.20.1)
115+
continue-on-error: true
116+
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_20_Mojang
117+
106118
- name: Run Bukkit unit tests across all versions (1.19.4)
107119
continue-on-error: true
108120
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_19_4
109121

122+
- name: Run Bukkit unit tests across all versions (Mojang Mapped 1.19.4)
123+
continue-on-error: true
124+
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_19_4_Mojang
125+
110126
- name: Run Bukkit unit tests across all versions (1.19.2)
111127
continue-on-error: true
112128
run: mvn clean package -pl :commandapi-bukkit-test-tests -P Platform.Bukkit -Dmaven.javadoc.skip=true -P Minecraft_1_19_2

commandapi-platforms/commandapi-bukkit/commandapi-bukkit-nms/commandapi-bukkit-1.20/src/main/java/dev/jorel/commandapi/nms/NMS_1_20_R1.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@
142142

143143
// Mojang-Mapped reflection
144144
/**
145-
* NMS implementation for Minecraft 1.20.
145+
* NMS implementation for Minecraft 1.20 and 1.20.1.
146146
*/
147-
@NMSMeta(compatibleWith = { "1.20" })
147+
@NMSMeta(compatibleWith = { "1.20", "1.20.1" })
148148
@RequireField(in = SimpleHelpMap.class, name = "helpTopics", ofType = Map.class)
149149
@RequireField(in = EntitySelector.class, name = "usesSelector", ofType = boolean.class)
150150
@RequireField(in = ItemInput.class, name = "tag", ofType = CompoundTag.class)

testAllVersions.sh

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# Exit script if any tests fails so they can be investigated
2+
set -e
3+
4+
runTest() {
5+
echo "Running tests for $1"
6+
mvn clean verify -Dmaven.javadoc.skip=true -P Platform.Bukkit -pl :commandapi-bukkit-test-tests -P $1
7+
}
8+
9+
# Test all versions
10+
# 1.20.5 & 1.20.6
11+
runTest Minecraft_1_20_5
12+
runTest Minecraft_1_20_5_Mojang
13+
14+
# 1.20.3 & 1.20.4
15+
runTest Minecraft_1_20_3
16+
17+
# 1.20.2
18+
runTest Minecraft_1_20_2
19+
20+
# 1.20 & 1.20.1
21+
runTest Minecraft_1_20
22+
runTest Minecraft_1_20_Mojang
23+
24+
# 1.19.4
25+
runTest Minecraft_1_19_4
26+
runTest Minecraft_1_19_4_Mojang
27+
28+
# 1.19.1 & 1.19.2
29+
runTest Minecraft_1_19_2
30+
31+
# 1.18 & 1.18.1
32+
runTest Minecraft_1_18
33+
34+
# 1.17
35+
runTest Minecraft_1_17
36+
37+
# 1.16.5
38+
runTest Minecraft_1_16_5

0 commit comments

Comments
 (0)