Create static method to create a dummy instance

Author: DerEchtePilz

commandapi-platforms/commandapi-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/config/BukkitConfigurationAdapter.java

@@ -17,6 +17,10 @@
 @ApiStatus.Internal
 public record BukkitConfigurationAdapter(YamlConfiguration config) implements ConfigurationAdapter<YamlConfiguration> {
 
+	public static BukkitConfigurationAdapter createDummyInstance() {
+		return new BukkitConfigurationAdapter(null);
+	}
+
 	@Override
 	public void setValue(String key, Object value) {
 		config.set(key, value);

commandapi-platforms/commandapi-bukkit/commandapi-bukkit-plugin-mojang-mapped/src/main/java/dev/jorel/commandapi/CommandAPIMain.java

@@ -21,12 +21,8 @@
 package dev.jorel.commandapi;
 
 import dev.jorel.commandapi.config.BukkitConfigurationAdapter;
-import dev.jorel.commandapi.config.ConfigGenerator;
-import dev.jorel.commandapi.config.ConfigurationAdapter;
-import dev.jorel.commandapi.config.DefaultBukkitConfig;
 import org.bukkit.Bukkit;
 import org.bukkit.configuration.file.FileConfiguration;
-import org.bukkit.configuration.file.YamlConfiguration;
 import org.bukkit.plugin.InvalidPluginException;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.plugin.java.JavaPlugin;
@@ -149,7 +145,7 @@ public void onEnable() {
 	@Override
 	public void saveDefaultConfig() {
 		File configFile = new File(getDataFolder(), "config.yml");
-		new BukkitConfigurationAdapter(null).saveDefaultConfig(getDataFolder(), configFile, getLogger());
+		BukkitConfigurationAdapter.createDummyInstance().saveDefaultConfig(getDataFolder(), configFile, getLogger());
 	}
 
 }

commandapi-platforms/commandapi-bukkit/commandapi-bukkit-plugin/src/main/java/dev/jorel/commandapi/CommandAPIMain.java

@@ -20,23 +20,19 @@
  *******************************************************************************/
 package dev.jorel.commandapi;
 
-import java.io.File;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Map.Entry;
-
 import dev.jorel.commandapi.config.BukkitConfigurationAdapter;
-import dev.jorel.commandapi.config.ConfigGenerator;
-import dev.jorel.commandapi.config.ConfigurationAdapter;
-import dev.jorel.commandapi.config.DefaultBukkitConfig;
 import org.bukkit.Bukkit;
 import org.bukkit.configuration.file.FileConfiguration;
-import org.bukkit.configuration.file.YamlConfiguration;
 import org.bukkit.plugin.InvalidPluginException;
 import org.bukkit.plugin.Plugin;
 import org.bukkit.plugin.java.JavaPlugin;
 
+import java.io.File;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+
 /**
  * Main CommandAPI plugin entrypoint
  */
@@ -149,6 +145,6 @@ public void onEnable() {
 	@Override
 	public void saveDefaultConfig() {
 		File configFile = new File(getDataFolder(), "config.yml");
-		new BukkitConfigurationAdapter(null).saveDefaultConfig(getDataFolder(), configFile, getLogger());
+		BukkitConfigurationAdapter.createDummyInstance().saveDefaultConfig(getDataFolder(), configFile, getLogger());
 	}
 }

commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/CommandAPIMain.java

@@ -8,18 +8,13 @@
 import com.velocitypowered.api.plugin.Plugin;
 import com.velocitypowered.api.plugin.annotation.DataDirectory;
 import com.velocitypowered.api.proxy.ProxyServer;
-import dev.jorel.commandapi.config.ConfigGenerator;
-import dev.jorel.commandapi.config.ConfigurationAdapter;
-import dev.jorel.commandapi.config.DefaultVelocityConfig;
 import dev.jorel.commandapi.config.VelocityConfigurationAdapter;
-import org.spongepowered.configurate.CommentedConfigurationNode;
 import org.spongepowered.configurate.ConfigurationNode;
 import org.spongepowered.configurate.yaml.NodeStyle;
 import org.spongepowered.configurate.yaml.YamlConfigurationLoader;
 
 import java.io.File;
 import java.io.IOException;
-import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.logging.Logger;
 
@@ -41,7 +36,7 @@ public CommandAPIMain(ProxyServer server, Logger logger, @DataDirectory Path dat
 		Path configFile = dataDirectory.resolve("config.yml");
 
 		// Create or update config
-		new VelocityConfigurationAdapter(null, null, null).saveDefaultConfig(configFile.getParent().toFile(), configFile.toFile(), null);
+		VelocityConfigurationAdapter.createDummyInstance().saveDefaultConfig(configFile.getParent().toFile(), configFile.toFile(), null);
 
 		// Load the file as a yaml node
 		ConfigurationNode configYAML;

commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/config/VelocityConfigurationAdapter.java

@@ -8,18 +8,19 @@
 
 import java.io.File;
 import java.io.IOException;
-import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
-import java.util.Map;
 import java.util.Set;
 import java.util.logging.Logger;
 
 public record VelocityConfigurationAdapter(YamlConfigurationLoader loader, CommentedConfigurationNode config, DefaultVelocityConfig defaultVelocityConfig) implements ConfigurationAdapter<ConfigurationNode> {
 
+	public static VelocityConfigurationAdapter createDummyInstance() {
+		return new VelocityConfigurationAdapter(null, null, null);
+	}
+
 	@Override
 	public void setValue(String key, Object value) {
 		try {