t

Author: wilsonsilva

lib/jsonrpc/configuration.rb

@@ -4,6 +4,7 @@ class Configuration
 
     def initialize
       @procedures = {}
+      @validate_procedure_signatures = true
     end
 
     def self.instance

lib/jsonrpc/middleware.rb

@@ -48,7 +48,7 @@ def handle_jsonrpc_request(req)
         return json_response(200, Response.new(id: e.request_id, error: error).to_h)
       end
 
-      validation_errors = @validator.validate(parsed)
+      validation_errors = @validator.validate(parsed) if JSONRPC.configuration.validate_procedure_signatures
 
       return json_response(200, validation_errors) if validation_errors
 

spec/jsonrpc/validator/single_request_spec.rb

@@ -70,7 +70,7 @@
 
     describe 'positional arguments' do
       context 'when the positional arguments are missing' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
           request = JSONRPC::Request.new(method: 'add', id: 'add-missing-positional-arguments')
           error = validator.validate(request)
 
@@ -82,7 +82,7 @@
       end
 
       context 'when the positional arguments are nil' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
           request = JSONRPC::Request.new(method: 'add', id: 'add-nil-positional-arguments', params: nil)
           error = validator.validate(request)
 
@@ -94,7 +94,7 @@
       end
 
       context 'when the positional arguments are empty' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
           request = JSONRPC::Request.new(method: 'add', id: 'add-empty-positional-arguments', params: [])
           error = validator.validate(request)
 
@@ -105,20 +105,8 @@
         end
       end
 
-      context 'when the positional arguments have the wrong type' do
-        it 'returns an invalid request error' do
-          request = JSONRPC::Request.new(method: 'add', id: 'add-type-positional-arguments', params: 1984)
-          error = validator.validate(request)
-
-          expect(error).to be_a(JSONRPC::InvalidParamsError)
-          expect(error.request_id).to eq('add-type-positional-arguments')
-          expect(error.data).to eq(method: 'add')
-          expect(error.message).to eq('Invalid method parameter(s).')
-        end
-      end
-
       context 'when the positional arguments have the wrong value' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
           request = JSONRPC::Request.new(method: 'add', id: 'add-value-positional-arguments', params: %w[one two])
           error = validator.validate(request)
 
@@ -130,7 +118,9 @@
       end
 
       context 'when the positional arguments have the wrong arity' do
-        xit 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
+          pending 'Post-MVP'
+
           request = JSONRPC::Request.new(method: 'add', id: 'add-arity-positional-arguments', params: [1984])
           error = validator.validate(request)
 
@@ -144,32 +134,27 @@
 
     describe 'named arguments' do
       context 'when the named arguments are missing' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
         end
       end
 
       context 'when the named arguments are nil' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
         end
       end
 
       context 'when the named arguments are empty' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
         end
       end
 
       context 'when the named arguments have the wrong arity' do
-        it 'returns an invalid request error' do
-        end
-      end
-
-      context 'when the named arguments have the wrong type' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
         end
       end
 
       context 'when the named arguments have the wrong value' do
-        it 'returns an invalid request error' do
+        it 'returns an invalid request params error' do
         end
       end
     end