Merge branch 'apex-enterprise-patterns:master' into master

Author: Reinier van den Assum

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,29 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+(A clear and concise description of what the bug is.)
+
+**To Reproduce**
+
+(Please provide a public github repo with a full SFDX project that demonstrates the problem. If the repro case can be followed with a single example Apex class against a scratch org with just the fflib-apex-common and fflib-apex-mocks project deployed into it, you don't need to provide a github repo)
+
+Steps to reproduce the behavior:
+1. Create a scratch org as follows....
+2. Run the following Anonymous Apex....
+3. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots and text of error observed**
+If applicable, add screenshots to help explain your problem. Also, paste the text of the raw error into the issue as well so that it can be found by others via search.
+
+**Version**
+Did you try to reproduce the problem against the latest fflib-apex-common code?

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/workflows/deploy.and.test.yml

@@ -0,0 +1,31 @@
+name: Create a Scratch Org, Push Source and Run Apex Tests
+
+on:
+  push:
+  pull_request_target:
+  workflow_dispatch:
+  
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          ref: ${{github.event.pull_request.head.ref}}
+          repository: ${{github.event.pull_request.head.repo.full_name}}
+      - name: Install SFDX CLI and authorize DevHub
+        uses: apex-enterprise-patterns/setup-sfdx@v1 #We're using a fork of https://github.com/sfdx-actions/setup-sfdx for safety
+        with:
+          sfdx-auth-url: ${{ secrets.DEVHUB_SFDXURL }}
+      - run: sfdx force:config:set defaultdevhubusername=SFDX-ENV -g #Even though the setup-sfdx action uses --setdefaultdevhubusername, it doesn't seem to stick since it uses --setdefaultusername so we brute force it here
+      - run: echo y | sfdx plugins:install shane-sfdx-plugins
+      - run: sfdx force:org:create -f config/project-scratch-def.json --setdefaultusername -d 1
+      - run: sfdx shane:github:src:install -c -g apex-enterprise-patterns -r fflib-apex-mocks -p sfdx-source/apex-mocks
+      - run: sfdx force:source:push
+      - run: sfdx force:apex:test:run -w 5
+      - name: Destroy scratch org
+        run: sfdx force:org:delete -p
+        if: always()
+

.gitignore

@@ -28,6 +28,13 @@ Referenced Packages/
 .vscode/
 .history/
 
+# IntelliJ IDE Related
+.idea/
+*.iml
+*.iws
+IlluminatedCloud/
+.project.license
+
 # SFDX Related
 .sfdx/
 sfdx-source/common-base/main/default/

README.md

@@ -1,7 +1,8 @@
 FFLib Apex Common
 =================
 
-[![Build Status](https://travis-ci.org/apex-enterprise-patterns/fflib-apex-common.svg)](https://travis-ci.org/apex-enterprise-patterns/fflib-apex-common) 
+![Push Source and Run Apex Tests](https://github.com/apex-enterprise-patterns/fflib-apex-common/workflows/Create%20a%20Scratch%20Org,%20Push%20Source%20and%20Run%20Apex%20Tests/badge.svg)
+
 
 **Dependencies:** Must deploy [ApexMocks](https://github.com/apex-enterprise-patterns/fflib-apex-mocks) before deploying this library
 

config/project-scratch-def.json

@@ -2,8 +2,8 @@
     "orgName": "apex-common",
     "edition": "Developer",
     "settings": {
-        "orgPreferenceSettings": {
-            "s1DesktopEnabled": true
+        "lightningExperienceSettings": {
+            "enableS1DesktopEnabled": true
         }
     }
 }

sfdx-project.json

@@ -7,5 +7,5 @@
     ],
     "namespace": "",
     "sfdcLoginUrl": "https://login.salesforce.com",
-    "sourceApiVersion": "48.0"
+    "sourceApiVersion": "53.0"
 }