refactor: reduce duplication in scanner benchmarks

More duplication in the stubbing (which is fine), and less duplication
in the scanner set-up (which is good to reduce, because we don't want
this drifting out of sync).

Author: wincent

bin/benchmarks/scanner.lua

@@ -21,6 +21,10 @@ benchmark({
   setup = function(config)
     collectgarbage()
     local scanner = nil
+    if config.stub then
+      -- For scanners that otherwise depend on Neovim for a list of candidates.
+      config.stub()
+    end
     if type(config.source) == 'string' then
       scanner = require(config.source)
     elseif type(config.source) == 'function' then
@@ -37,10 +41,6 @@ benchmark({
       local name = output:match('"sockname":%s*"([^"]+)"') or fallback
       scanner.set_sockname(name)
     end
-    if config.stub then
-      -- For scanners that otherwise depend on Neovim for a list of candidates.
-      config.stub(scanner)
-    end
     return scanner
   end,
 

data/wincent/commandt/benchmark/configs/scanner.lua

@@ -5,21 +5,11 @@ return {
     {
       name = 'buffer',
       source = function()
+        local command = require('wincent.commandt').default_options().finders.buffer.candidates()
         local scanner = require('wincent.commandt.private.scanners.list').scanner
         return {
           scanner = function()
-            local handles = vim.api.nvim_list_bufs()
-            local paths = {}
-            for _, handle in ipairs(handles) do
-              if vim.api.nvim_buf_is_loaded(handle) then
-                local name = vim.api.nvim_buf_get_name(handle)
-                if name ~= '' then
-                  local relative = vim.fn.fnamemodify(name, ':~:.')
-                  table.insert(paths, relative)
-                end
-              end
-            end
-            return scanner(paths)
+            return scanner(command)
           end,
         }
       end,
@@ -222,22 +212,32 @@ return {
     {
       name = 'find',
       source = function()
-        local command = 'find -L . -type f -print0 2> /dev/null'
-        local drop = 2
+        local command = require('wincent.commandt').default_options().finders.find.command('')
         local scanner = require('wincent.commandt.private.scanners.command').scanner
         return {
           scanner = function()
-            return scanner(command, drop)
+            return scanner(command)
           end,
         }
       end,
+      stub = function()
+        assert(_G.vim == nil)
+        _G.vim = {
+          startswith = function()
+            return false
+          end,
+        }
+      end,
+      unstub = function()
+        _G.vim = nil
+      end,
       times = times,
       skip_in_ci = false,
     },
     {
       name = 'git',
       source = function()
-        local command = 'git ls-files --exclude-standard --cached -z 2> /dev/null'
+        local command = require('wincent.commandt').default_options().finders.git.command('', {})
         local scanner = require('wincent.commandt.private.scanners.command').scanner
         return {
           scanner = function()
@@ -251,14 +251,25 @@ return {
     {
       name = 'rg',
       source = function()
-        local command = 'rg --files --null 2> /dev/null'
+        local command = require('wincent.commandt').default_options().finders.rg.command('')
         local scanner = require('wincent.commandt.private.scanners.command').scanner
         return {
           scanner = function()
             return scanner(command)
           end,
         }
       end,
+      stub = function()
+        assert(_G.vim == nil)
+        _G.vim = {
+          startswith = function()
+            return false
+          end,
+        }
+      end,
+      unstub = function()
+        _G.vim = nil
+      end,
       times = times,
       skip_in_ci = true,
     },