Revert "chore: cleanup the inspect method"

This reverts commit fade24f.

Author: fang2hou

Modules/Item/Inspect.lua

@@ -55,7 +55,7 @@ local C_Item_GetItemQualityColor = C_Item.GetItemQualityColor
 local C_Item_IsCorruptedItem = C_Item.IsCorruptedItem
 local C_Spell_GetSpellTexture = C_Spell.GetSpellTexture
 
-local guids = {}
+local guids, inspecting = {}, false
 
 local slots = {
 	{ index = 1, name = HEADSLOT },
@@ -862,37 +862,8 @@ local function ShowInspectItemListFrame(unit, parent, ilevel, maxLevel)
 end
 
 function IL:Inspect()
-	---@type nil|false|{
-	--- class: string,
-	--- expired: integer,
-	--- guid: WOWGUID,
-	--- hp: number,
-	--- ilevel: integer,
-	--- level: number,
-	--- name: string,
-	--- realm: string,
-	--- spec: string|nil,
-	--- timer: integer,
-	--- unit: UnitToken,
-	--- weaponLevel: number|nil,
-	--- isArtifact: boolean|nil,
-	--- maxLevel: number|nil,
-	---}
-	local inspecting -- inspecting can be false or table
-
-	local function clearCurrentInspection()
-		if inspecting then
-			if type(inspecting) == "table" then
-				LibSchedule:RemoveTask(inspecting.guid)
-				inspecting = nil
-			else
-				inspecting = false
-			end
-		end
-	end
-
 	hooksecurefunc("ClearInspectPlayer", function()
-		clearCurrentInspection()
+		inspecting = false
 	end)
 
 	-- @trigger UNIT_INSPECT_STARTED
@@ -928,39 +899,42 @@ function IL:Inspect()
 	end)
 
 	-- @trigger UNIT_INSPECT_READY
-	LibEvent:attachEvent("INSPECT_READY", function(_, guid)
+	LibEvent:attachEvent("INSPECT_READY", function(this, guid)
 		if not guids[guid] then
 			return
 		end
-
 		LibSchedule:AddTask({
 			identity = guid,
 			timer = 0.5,
 			elasped = 0.8,
 			expired = GetTime() + 4,
-			data = inspecting,
-			onTimeout = function(task)
-				clearCurrentInspection()
+			data = guids[guid],
+			onTimeout = function(self)
+				inspecting = false
 			end,
-			onExecute = function(task)
-				local count, ilevel, _, weaponLevel, isArtifact, maxLevel =
-					LibItemInfo:GetUnitItemLevel(inspecting.unit)
+			onExecute = function(self)
+				local count, ilevel, _, weaponLevel, isArtifact, maxLevel = LibItemInfo:GetUnitItemLevel(self.data.unit)
 				if ilevel <= 0 then
 					return true
 				end
 				if count == 0 and ilevel > 0 then
-					inspecting.timer = time()
-					inspecting.name = UnitName(inspecting.unit)
-					inspecting.class = select(2, UnitClass(inspecting.unit))
-					inspecting.ilevel = ilevel
-					inspecting.maxLevel = maxLevel
-					inspecting.spec = GetInspectSpec(inspecting.unit)
-					inspecting.hp = UnitHealthMax(inspecting.unit)
-					inspecting.weaponLevel = weaponLevel
-					inspecting.isArtifact = isArtifact
-					LibEvent:trigger("UNIT_INSPECT_READY", inspecting)
+					--if (UnitIsVisible(self.data.unit) or self.data.ilevel == ilevel) then
+					self.data.timer = time()
+					self.data.name = UnitName(self.data.unit)
+					self.data.class = select(2, UnitClass(self.data.unit))
+					self.data.ilevel = ilevel
+					self.data.maxLevel = maxLevel
+					self.data.spec = GetInspectSpec(self.data.unit)
+					self.data.hp = UnitHealthMax(self.data.unit)
+					self.data.weaponLevel = weaponLevel
+					self.data.isArtifact = isArtifact
+					LibEvent:trigger("UNIT_INSPECT_READY", self.data)
 					inspecting = false
 					return true
+					--else
+					--    self.data.ilevel = ilevel
+					--    self.data.maxLevel = maxLevel
+					--end
 				end
 			end,
 		})
@@ -985,7 +959,7 @@ function IL:Inspect()
 	end)
 
 	--高亮橙裝和武器
-	LibEvent:attachTrigger("INSPECT_ITEMFRAME_UPDATED", function(_, itemframe)
+	LibEvent:attachTrigger("INSPECT_ITEMFRAME_UPDATED", function(self, itemframe)
 		local r, g, b = 0, 0.9, 0.9
 		if itemframe.quality and itemframe.quality > 4 then
 			r, g, b = C_Item_GetItemQualityColor(itemframe.quality)