fix: use another solution to override

Author: fang2hou

Modules/Skins/Blizzard/CooldownViewer.lua

@@ -10,11 +10,23 @@ local ipairs = ipairs
 local pairs = pairs
 
 local hookFunctions = {
-	RefreshSpellCooldownInfo = S.CooldownManager_RefreshSpellCooldownInfo,
-	OnSpellActivationOverlayGlowShowEvent = S.CooldownManager_ShowGlowEvent,
-	OnSpellActivationOverlayGlowHideEvent = S.CooldownManager_HideGlowEvent,
-	RefreshOverlayGlow = S.CooldownManager_RefreshOverlayGlow,
-	SetTimerShown = S.CooldownManager_SetTimerShown,
+	RefreshSpellCooldownInfo = ES.CooldownManager_RefreshSpellCooldownInfo,
+	OnSpellActivationOverlayGlowShowEvent = function(...)
+		if not S.db or not S.db.cooldownViewer.general.useBlizzardGlow then
+			return ES.CooldownManager_ShowGlowEvent(...)
+		end
+	end,
+	OnSpellActivationOverlayGlowHideEvent = function(...)
+		if not S.db or not S.db.cooldownViewer.general.useBlizzardGlow then
+			return ES.CooldownManager_HideGlowEvent(...)
+		end
+	end,
+	RefreshOverlayGlow = function(...)
+		if not S.db or not S.db.cooldownViewer.general.useBlizzardGlow then
+			return ES.CooldownManager_RefreshOverlayGlow(...)
+		end
+	end,
+	SetTimerShown = ES.CooldownManager_SetTimerShown,
 }
 
 function ES:CooldownManager_SkinItemFrame(frame)
@@ -39,18 +51,6 @@ function ES:CooldownManager_SkinItemFrame(frame)
 	end
 end
 
-function S:RefreshElvUICustomGlowOnCooldownManager()
-	if self.db.cooldownViewer.general.useBlizzardGlow then
-		hookFunctions.OnSpellActivationOverlayGlowHideEvent = nil
-		hookFunctions.OnSpellActivationOverlayGlowShowEvent = nil
-		hookFunctions.RefreshOverlayGlow = nil
-	else
-		hookFunctions.OnSpellActivationOverlayGlowHideEvent = S.CooldownManager_HideGlowEvent
-		hookFunctions.OnSpellActivationOverlayGlowShowEvent = S.CooldownManager_ShowGlowEvent
-		hookFunctions.RefreshOverlayGlow = S.CooldownManager_RefreshOverlayGlow
-	end
-end
-
 local function UpdateFrameAndStrata(frame, config)
 	frame:SetFrameStrata(S.db.cooldownViewer[config].frameStrata)
 	frame:SetFrameLevel(S.db.cooldownViewer[config].frameLevel)
@@ -187,8 +187,6 @@ function S:Blizzard_CooldownViewer_Modification()
 	if self.db.cooldownViewer.essential.enable then
 		self:CooldownManager_HandleViewer(_G.EssentialCooldownViewer)
 	end
-
-	self:RefreshElvUICustomGlowOnCooldownManager()
 end
 
 function S:Blizzard_CooldownViewer()

Options/Skins.lua

@@ -518,7 +518,7 @@ options.cooldownViewer = {
 			end,
 			set = function(info, value)
 				E.private.WT.skins.cooldownViewer[info[#info - 1]][info[#info]] = value
-				S:RefreshElvUICustomGlowOnCooldownManager()
+				E:StaticPopup_Show("PRIVATE_RL")
 			end,
 			disabled = function()
 				return not E.private.WT.skins.cooldownViewer.enable