Skip to content

Commit 396ba97

Browse files
committed
Fix error types
1 parent 3b579b8 commit 396ba97

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

tests/test_wind_farm.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,11 @@ def test_initialization_dataframe(self):
4848

4949
def test_initialization_1(self):
5050
"""test catching error when wind_turbine_fleet not provided as list"""
51-
msg = 'Wind turbine fleet not provided properly.'
51+
msg = 'Wind turbine must be provided as WindTurbine object'
5252
with pytest.raises(ValueError, match=msg):
53-
WindFarm(wind_turbine_fleet=[{'wind_turbine': 'turbine',
54-
'number_of_turbines': 2}, 'dummy'])
53+
WindFarm(wind_turbine_fleet={'wind_turbine': 'turbine',
54+
'number_of_turbines': 2},
55+
name='dummy')
5556

5657
def test_initialization_2(self):
5758
"""test catching error when WindTurbine in wind_turbine_fleet
@@ -71,7 +72,7 @@ def test_initialization_3(self):
7172
WindTurbine(**self.test_turbine_2)],
7273
'number_of_turbines': [3, 2]})
7374
msg = 'Missing wind_turbine key/column in wind_turbine_fleet'
74-
with pytest.raises(ValueError, match=msg):
75+
with pytest.raises(KeyError, match=msg):
7576
WindFarm(wind_turbine_fleet=wind_turbine_fleet)
7677

7778
def test_initialization_4(self, recwarn):

windpowerlib/wind_farm.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ def check_and_complete_wind_turbine_fleet(self):
135135
'Wind turbine must be provided as WindTurbine object '
136136
'but was provided as {}.'.format(type(turbine)))
137137
except KeyError:
138-
raise ValueError('Missing wind_turbine key/column in '
139-
'wind_turbine_fleet parameter.')
138+
raise KeyError('Missing wind_turbine key/column in '
139+
'wind_turbine_fleet parameter.')
140140

141141
# add columns for number of turbines and total capacity if they don't
142142
# yet exist
@@ -161,7 +161,7 @@ def check_and_complete_wind_turbine_fleet(self):
161161
else:
162162
self.wind_turbine_fleet.loc[ix, 'number_of_turbines'] = \
163163
number_of_turbines
164-
except ValueError:
164+
except TypeError:
165165
raise ValueError(msg.format(row['wind_turbine']))
166166

167167
# calculate total capacity if necessary and check that total capacity
@@ -172,7 +172,7 @@ def check_and_complete_wind_turbine_fleet(self):
172172
self.wind_turbine_fleet.loc[ix, 'total_capacity'] = \
173173
row['number_of_turbines'] * \
174174
row['wind_turbine'].nominal_power
175-
except ValueError:
175+
except TypeError:
176176
raise ValueError(
177177
'Total capacity of turbines of type {turbine} cannot '
178178
'be deduced. Please check if the nominal power of the '

0 commit comments

Comments
 (0)