Skip to content

Commit 5424afa

Browse files
committed
Manage todos
1 parent 0bd797b commit 5424afa

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

windpowerlib/power_curves.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ def smooth_power_curve(power_curve_wind_speeds, power_curve_values,
1616
block_width=0.5,
1717
standard_deviation_method='turbulence_intensity',
1818
mean_gauss=0, **kwargs):
19-
# TODO: All functions in this module have to work without pandas
2019
r"""
2120
Smoothes the input power curve values by using a gaussian distribution.
2221
@@ -259,6 +258,8 @@ def density_correct_power_curve(density, power_curve_wind_speeds,
259258
at Reiner Lemoine Institute, 2014, p. 13
260259
261260
"""
261+
# TODO: is this error raising needed? Density does not have default value
262+
# e.g. there would be an error message also without the next lines.
262263
if density is None:
263264
raise TypeError("`density` is None. For the calculation with a " +
264265
"density corrected power curve mean density at hub " +

windpowerlib/power_output.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,8 @@ def power_curve_density_correction(wind_speed, power_curve_wind_speeds,
226226
at Reiner Lemoine Institute, 2014, p. 13
227227
228228
"""
229+
# TODO: is this error raising needed? Density does not have default value
230+
# e.g. there would be an error message also without the next lines.
229231
if density is None:
230232
raise TypeError("`density` is None. For the calculation with a " +
231233
"density corrected power curve density at hub " +

windpowerlib/turbine_cluster_modelchain.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def wind_farm_power_curve(self, wind_farm, **kwargs):
164164
if self. density_correction:
165165
pass # TODO: restrictions (density needed)
166166
if self.wake_losses_method is not None:
167-
if self.wind_object.efficiency is None: # TODO if not...
167+
if wind_farm.efficiency is None:
168168
raise KeyError(
169169
"wind_farm_efficiency is needed if " +
170170
"`wake_losses_method´ is '{0}', but ".format(

0 commit comments

Comments
 (0)