Merge pull request #92 from vezeli/fix-turbine

Fix turbine

Author: uvchik

tests/test_wind_turbine.py

@@ -110,3 +110,14 @@ def test_wrongly_defined_to_group_method(self):
             "parameter are mutually exclusive.",
         ):
             e_t_1.to_group(5, 3000)
+
+    def test_create_unphysical_turbine(self):
+        err_msg = "1/2rotor_diameter cannot be greater than hub_height"
+        char = {
+           'hub_height': 80,
+           'rotor_diameter': 160,
+           'turbine_type': 'DUMMY 3',
+           'path': self.source
+        }
+        with pytest.raises(ValueError, match=err_msg):
+            WindTurbine(**char)

windpowerlib/wind_turbine.py

@@ -175,6 +175,11 @@ def __init__(
                 if self.rotor_diameter is None and turbine_data is not None:
                     self.rotor_diameter = float(turbine_data["rotor_diameter"])
 
+        if self.rotor_diameter:
+            if self.hub_height <= 0.5*self.rotor_diameter:
+                msg = "1/2rotor_diameter cannot be greater than hub_height"
+                raise ValueError(msg)
+
         if self.power_curve is None and self.power_coefficient_curve is None:
             msg = (
                 "The WindTurbine has been initialised without a power curve"