Merge pull request #295 from AugustoL/fix-smart-token

AugustoL · web-flow · commit 86d842916ed1 · 2017-10-12T17:22:51.000+02:00
approve before call in approveData in SmartToken
diff --git a/contracts/SmartToken.sol b/contracts/SmartToken.sol
@@ -32,9 +32,10 @@ contract SmartToken is StandardToken {
   function approveData(address _spender, uint256 _value, bytes _data) returns (bool) {
     require(_spender != address(this));
 
+    super.approve(_spender, _value);
+
     require(_spender.call(_data));
 
-    super.approve(_spender, _value);
     return true;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -32,9 +32,10 @@ contract SmartToken is StandardToken {`
`32`	`32`	`function approveData(address _spender, uint256 _value, bytes _data) returns (bool) {`
`33`	`33`	`require(_spender != address(this));`
`34`	`34`
	`35`	`+ super.approve(_spender, _value);`
	`36`	`+`
`35`	`37`	`require(_spender.call(_data));`
`36`	`38`
`37`		`- super.approve(_spender, _value);`
`38`	`39`	`return true;`
`39`	`40`	`}`
`40`	`41`