feat: implement quiet mode to filter verbose logs #7478

claude · 2026-01-02T08:53:18Z

Summary

Adds QUIET_MODE environment variable (set to "true" or "1" to enable) that filters noise logs
Marks worker per-job logs with windmill_verbose target that gets filtered in quiet mode
Increases periodic log intervals by 10x when quiet mode is enabled

Changes

`backend/windmill-common/src/tracing_init.rs`

Added QUIET_MODE lazy_static env var
Added VERBOSE_TARGET constant ("windmill_verbose") for logs that should be suppressed
Created create_targets_filter() helper that filters the verbose target when quiet mode is on

`backend/windmill-worker/src/handle_child.rs`

Changed periodic logs to use VERBOSE_TARGET:
- "job still running" log
- "worker memory snapshot" log
- "job finished" log
- "child process took" log
Increased "still running" log interval from every tick (500ms) to every 10 ticks (5s) in quiet mode
Increased memory snapshot log interval from every 10 ticks (5s) to every 100 ticks (50s) in quiet mode

`backend/windmill-worker/src/worker.rs`

Changed per-job logs to use VERBOSE_TARGET:
- "started handling of job" log
- "fetched job" log
Added quiet mode notification in job logs

Test plan

Run worker with QUIET_MODE=true and verify verbose logs are suppressed
Run worker without QUIET_MODE and verify all logs appear normally
Verify periodic logs have increased intervals in quiet mode

Closes #7477

🤖 Generated with Claude Code

Add QUIET_MODE environment variable (set to "true" or "1" to enable) that: - Filters logs with the "windmill_verbose" target via tracing_init - Increases frequency of periodic logs by 10x when enabled - Marks per-job worker logs as verbose so they are suppressed in quiet mode Key changes: - Add QUIET_MODE lazy_static and VERBOSE_TARGET constant to tracing_init.rs - Create create_targets_filter() helper that filters windmill_verbose target - Mark periodic "still running" and "memory snapshot" logs with VERBOSE_TARGET - Mark per-job "fetched job", "started handling", "job finished" logs as verbose - Increase memory snapshot interval from every 10 ticks to every 100 ticks in quiet mode - Increase "still running" log interval from every tick to every 10 ticks in quiet mode - Add quiet mode notification in job logs Closes #7477 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>

cloudflare-workers-and-pages · 2026-01-02T08:55:39Z

Deploying windmill with Cloudflare Pages

Latest commit:	`1c1c877`
Status:	✅ Deploy successful!
Preview URL:	https://a2a75fb8.windmill.pages.dev
Branch Preview URL:	https://claude-issue-7477-20260102-0.windmill.pages.dev

View logs

claude · 2026-01-06T18:28:23Z

Claude finished @claude[bot]'s task in 1m 51s —— View job

Code Review: Quiet Mode Implementation

Tasks

Read and analyze the changed files
Review code quality and best practices
Check for potential bugs or issues
Evaluate performance considerations
Assess security implications
Provide comprehensive feedback with inline comments

Summary

This PR implements a quiet mode feature that filters verbose worker logs when enabled via the QUIET environment variable. The implementation is well-structured and follows existing patterns in the codebase.

General Observations

Strengths:

Clean refactoring: The create_targets_filter() helper function properly encapsulates the filter logic and removes code duplication
Good use of the existing tracing infrastructure with the target: parameter
Appropriate use of lazy_static! for the environment variable check
The frequency reduction for periodic logs (10x less frequent in quiet mode) is a sensible approach

Issues Found:

Naming Consistency - See inline comment on tracing_init.rs:41
Comment-Code Mismatch - See inline comment on handle_child.rs:704
Interval Behavior Clarification - See inline comment on handle_child.rs:728

Security & Performance

✅ No security concerns - this only affects logging verbosity
✅ Performance impact is positive - reduces log I/O in quiet mode
✅ Environment variable reading uses lazy_static! so it's evaluated once at startup

Testing Instructions

To verify these changes through the application:

Deploy a Windmill worker with the QUIET=true environment variable set. Run a script or flow that takes several seconds to complete and observe the worker logs. In quiet mode, you should see significantly fewer "job still running", "memory snapshot", and "fetched job" log entries compared to running without QUIET=true. Additionally, check that the job execution log includes the line "Quiet mode enabled: verbose service logs are suppressed" confirming the mode is active.

claude · 2026-01-06T18:29:59Z

backend/windmill-worker/src/handle_child.rs

        Err(Error::NotFound("not yet initialized".to_string()));

    loop {
        tokio::select!(


The comment mentions "update the last_ping column every 5 seconds (or 50 seconds in quiet mode)" but the quiet mode change only affects log frequency, not the ping interval. The ping frequency is still controlled by the update_job_row logic on line 733 and is unchanged.

Suggested change

tokio::select!(

// update the last_ping column every 5 seconds (or 50 seconds in quiet mode)

Consider updating to:

Suggested change

tokio::select!(

// Log memory snapshot and ping status (in quiet mode, logs emit 10x less frequently)

claude · 2026-01-06T18:30:05Z

backend/windmill-common/src/tracing_init.rs


 lazy_static::lazy_static! {
    pub static ref JSON_FMT: bool = std::env::var("JSON_FMT").map(|x| x == "true").unwrap_or(false);
+    pub static ref QUIET_MODE: bool = std::env::var("QUIET").map(|x| x == "true" || x == "1").unwrap_or(false);


There's an existing QUIET_LOGS environment variable defined in windmill-common/src/lib.rs:171 that also controls log verbosity. Having both QUIET and QUIET_LOGS could confuse users.

Consider either:

Reusing QUIET_LOGS for this feature

Documenting the difference clearly (e.g., QUIET_LOGS for conditional code checks vs QUIET for tracing filter)

Consolidating both into a single env var

claude · 2026-01-06T18:30:13Z

backend/windmill-worker/src/handle_child.rs

-                tracing::info!("job {job_id} on {worker_name} in {w_id} still running.  mem: {current_mem}kB, peak mem: {mem_peak}kB");
+                // In quiet mode, emit "still running" logs 10x less frequently
+                let still_running_interval = if *QUIET_MODE { 10 } else { 1 };
+                if i % still_running_interval == 0 {


Note: With still_running_interval = 10, the condition i % 10 == 0 means the first "still running" log will appear at tick 10 (5 seconds) in quiet mode, whereas normally it appears at every tick.

At tick 1: 1 % 10 = 1 ≠ 0 → no log
At tick 10: 10 % 10 = 0 → log

This is likely the intended behavior, just confirming it's not accidental that the first few ticks are skipped.

claude bot mentioned this pull request Jan 2, 2026

implement quiet mode to filter noise logs #7477

Closed

Update tracing_init.rs

e96b670

rubenfiszel marked this pull request as ready for review January 6, 2026 18:28

rubenfiszel requested review from alpetric, hugocasa and rubenfiszel as code owners January 6, 2026 18:28

claude bot commented Jan 6, 2026

View reviewed changes

rubenfiszel added 2 commits January 6, 2026 18:32

Update worker.rs

37f6dc9

Remove target from tracing info logs

1c1c877

rubenfiszel merged commit 62bb11e into main Jan 6, 2026
8 checks passed

rubenfiszel deleted the claude/issue-7477-20260102-0846 branch January 6, 2026 18:39

github-actions bot locked and limited conversation to collaborators Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: implement quiet mode to filter verbose logs #7478

feat: implement quiet mode to filter verbose logs #7478

claude bot commented Jan 2, 2026

Uh oh!

cloudflare-workers-and-pages bot commented Jan 2, 2026 •

edited

Loading

Uh oh!

claude bot commented Jan 6, 2026 •

edited

Loading

Uh oh!

claude bot Jan 6, 2026

Uh oh!

claude bot Jan 6, 2026

Uh oh!

claude bot Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	tokio::select!(
	// update the last_ping column every 5 seconds (or 50 seconds in quiet mode)

	tokio::select!(
	// Log memory snapshot and ping status (in quiet mode, logs emit 10x less frequently)

feat: implement quiet mode to filter verbose logs #7478

feat: implement quiet mode to filter verbose logs #7478

Conversation

claude bot commented Jan 2, 2026

Summary

Changes

backend/windmill-common/src/tracing_init.rs

backend/windmill-worker/src/handle_child.rs

backend/windmill-worker/src/worker.rs

Test plan

Uh oh!

cloudflare-workers-and-pages bot commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying windmill with Cloudflare Pages

Uh oh!

claude bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review: Quiet Mode Implementation

Tasks

Summary

General Observations

Security & Performance

Testing Instructions

Uh oh!

claude bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

claude bot Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`backend/windmill-common/src/tracing_init.rs`

`backend/windmill-worker/src/handle_child.rs`

`backend/windmill-worker/src/worker.rs`

cloudflare-workers-and-pages bot commented Jan 2, 2026 •

edited

Loading

claude bot commented Jan 6, 2026 •

edited

Loading