Skip to content

Conversation

@alpetric
Copy link
Collaborator

@alpetric alpetric commented Jan 6, 2026

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 6, 2026

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: f98d909
Status: ✅  Deploy successful!
Preview URL: https://b5461433.windmill.pages.dev
Branch Preview URL: https://alp-gpg-git-init.windmill.pages.dev

View logs

@claude
Copy link
Contributor

claude bot commented Jan 6, 2026

Claude finished @alpetric's task in 1m 0s —— View job


Review of PR #7508

  • Gather context and understand the changes
  • Review code quality and best practices
  • Check for potential bugs or issues
  • Provide comprehensive feedback

Summary

This PR updates the gitInitRepo hub script path from version 28090 to version 28109. The change addresses a bug where the git sync init script fails when the WM_EMAIL environment variable doesn't match the email configured in the GPG resource.

Changes

File Change
frontend/src/lib/hubPaths.json:24 hub/28090/...hub/28109/...

Review

Code Quality: The change is minimal and follows the established pattern for hub path updates in this file.

Best Practices: Versioning hub scripts via numeric IDs allows for backwards-compatible updates without breaking existing deployments.

No Issues Found: This is a straightforward configuration change that points to an updated hub script version.

Context

The gitInitRepo hub path is used in three locations:

  • PushWorkspaceModal.svelte - For initializing git repos during workspace push
  • PullWorkspaceModal.svelte - For initializing git repos during workspace pull
  • GitSyncContext.svelte.ts - For general git sync repository initialization

The updated hub script (version 28109) likely contains a fix that properly handles cases where the Windmill user email (WM_EMAIL) differs from the email associated with the GPG key resource, which is necessary for signed commits.

Verdict

LGTM ✅ - This is a simple, low-risk configuration update that fixes a legitimate edge case in the git sync initialization workflow.


Testing Instructions

To verify this fix, navigate to Workspace Settings > Git Sync and configure a git repository with GPG signing enabled. Use a GPG resource where the email in the GPG key differs from your Windmill account email. Then trigger a git sync initialization (either via Push or Pull workspace). The initialization should now succeed without email mismatch errors.

@rubenfiszel rubenfiszel merged commit e935f62 into main Jan 6, 2026
7 checks passed
@rubenfiszel rubenfiszel deleted the alp/gpg_git_init branch January 6, 2026 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants