Skip to content

chore: upgrade rquickjs from 0.8 to 0.11#8233

Merged
rubenfiszel merged 1 commit intomainfrom
rquickjs-update
Mar 5, 2026
Merged

chore: upgrade rquickjs from 0.8 to 0.11#8233
rubenfiszel merged 1 commit intomainfrom
rquickjs-update

Conversation

@rubenfiszel
Copy link
Contributor

Summary

What changed in rquickjs 0.8→0.11

  • 0.9.0: Switched underlying engine from quickjs to quickjs-ng (better perf)
  • 0.10.0: no_std support, PromiseHook bindings, bug fixes
  • 0.11.0: Proxy object, eval filename option, iterator support

Test plan

  • cargo check passes (no feature flags)
  • cargo check --features quickjs passes
  • cargo test --features quickjs -p windmill-jseval — 63/63 tests pass
  • Backend server starts and responds on /api/version

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link
Contributor

claude bot commented Mar 5, 2026

Claude finished @rubenfiszel's task in 50s —— View job


PR Review: Upgrade rquickjs from 0.8 to 0.11

  • Gather context and review diff
  • Review changes
  • Post review

Verdict: Looks good

This is a clean dependency version bump with no source code changes. Here's what I verified:

Changes reviewed:

  • backend/Cargo.toml: rquickjs version bumped from "0.8" to "0.11", same feature flags (futures, parallel, macro) — correct and minimal.
  • backend/Cargo.lock: Transitive dependency updates are all expected:
    • rquickjs, rquickjs-core, rquickjs-macro, rquickjs-sys all move from 0.8.1 → 0.11.0
    • convert_case 0.6.0 → 0.10.0 (used by rquickjs-macro)
    • relative-path 1.9.3 → 2.0.1 (used by rquickjs-core)
    • Removes duplicate proc-macro-crate v1.3.1 (consolidates to v3.4.0)
    • rquickjs-core adds hashbrown 0.16.0 dependency

No concerns found:

  • No API-breaking changes — the feature flags are unchanged and no source modifications were needed
  • The switch to quickjs-ng engine (happening at rquickjs 0.9) is a well-known improvement for performance
  • Lock file changes are consistent with what's expected from this version bump
  • No new security-sensitive dependencies introduced

Testing:
The PR description confirms cargo check, cargo check --features quickjs, and all 63 quickjs tests pass — which covers the important validation paths.


Reproduction / Verification Instructions

This is a backend dependency upgrade with no user-facing UI changes. To verify: ensure the Windmill backend starts correctly and any scripts using the QuickJS runtime (JavaScript evaluations in workflows) continue to execute as expected. No specific app navigation is needed — the change is transparent to end users.

@rubenfiszel rubenfiszel merged commit eab789b into main Mar 5, 2026
12 of 13 checks passed
@rubenfiszel rubenfiszel deleted the rquickjs-update branch March 5, 2026 05:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant