Skip to content

fix(cli): make wmill init generated skills respect nonDottedPaths config#8377

Merged
rubenfiszel merged 5 commits intomainfrom
docs/non-dotted-paths-convention
Mar 15, 2026
Merged

fix(cli): make wmill init generated skills respect nonDottedPaths config#8377
rubenfiszel merged 5 commits intomainfrom
docs/non-dotted-paths-convention

Conversation

@rubenfiszel
Copy link
Contributor

@rubenfiszel rubenfiszel commented Mar 15, 2026

Summary

  • Skills generated by wmill init now adapt to the nonDottedPaths setting in wmill.yaml
  • Uses placeholders in skill templates ({{FLOW_SUFFIX}}, {{RAW_APP_SUFFIX}}, {{INLINE_SCRIPT_NAMING}}) resolved at init time
  • When nonDottedPaths: true (default for new inits): skills reference __flow, __raw_app, and document non-dotted inline script naming (a.ts)
  • When nonDottedPaths: false (legacy): skills reference .flow, .raw_app, and document dotted inline script naming (a.inline_script.ts)

Verified

  • wmill init on fresh project → nonDottedPaths: true → skills use __flow, no .inline_script.
  • wmill init with existing wmill.yaml (nonDottedPaths: false) → skills use .flow, .inline_script.
  • No unreplaced {{...}} placeholders in either case

Test plan

  • wmill init --use-default on fresh directory → skills use __flow convention
  • wmill init --use-default with pre-existing wmill.yaml (nonDottedPaths: false) → skills use .flow convention
  • No leftover placeholders in generated skills

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@claude
Copy link
Contributor

claude bot commented Mar 15, 2026

Claude finished @rubenfiszel's task in 1m 3s —— View job


Review of PR #8377

  • Gather context and read the diff
  • Verify documentation accuracy against codebase
  • Post review feedback

LGTM — This is a clean, well-structured documentation addition. I verified all references against the codebase:

  • getNonDottedPaths(), setNonDottedPaths(), getFolderSuffix() all exist in cli/src/utils/resource_folders.ts
  • newPathAssigner() with skipInlineScriptSuffix option exists in cli/windmill-utils-internal/src/path-utils/path-assigner.ts
  • The nonDottedPaths key in wmill.yaml is correctly referenced (parsed at resource_folders.ts:83)
  • The table of dotted vs non-dotted naming is consistent with the DOTTED_SUFFIXES / NON_DOTTED_SUFFIXES constants in the code
  • The mention of extractInlineScripts*() is accurate — those functions are used in sync.ts, flow_metadata.ts, and app_metadata.ts

No issues found. The documentation accurately captures the convention and will help prevent regressions like the one fixed in #8375.

Reproduce / Verify

This PR only modifies CLAUDE.md. To verify, open the file in the repository (or view it rendered on the PR's "Files changed" tab) and confirm the new "CLI: nonDottedPaths Convention" section renders correctly — the table, code block, and key file references should all display properly.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2026

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8b9f5f6
Status: ✅  Deploy successful!
Preview URL: https://5d4261ae.windmill.pages.dev
Branch Preview URL: https://docs-non-dotted-paths-conven.windmill.pages.dev

View logs

rubenfiszel and others added 2 commits March 15, 2026 04:50
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rubenfiszel rubenfiszel changed the title docs: add nonDottedPaths convention to CLAUDE.md docs: add nonDottedPaths convention to cli generated skills Mar 15, 2026
@rubenfiszel rubenfiszel changed the title docs: add nonDottedPaths convention to cli generated skills fix(cli): make wmill init generated skills respect nonDottedPaths config Mar 15, 2026
rubenfiszel and others added 2 commits March 15, 2026 05:01
…s.ts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rubenfiszel rubenfiszel merged commit b1b9c98 into main Mar 15, 2026
6 of 7 checks passed
@rubenfiszel rubenfiszel deleted the docs/non-dotted-paths-convention branch March 15, 2026 05:05
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant