Skip to content

fix: windows volume mount symlinks for integration tests#8431

Merged
rubenfiszel merged 1 commit intomainfrom
fix-windows-integration-tests
Mar 18, 2026
Merged

fix: windows volume mount symlinks for integration tests#8431
rubenfiszel merged 1 commit intomainfrom
fix-windows-integration-tests

Conversation

@rubenfiszel
Copy link
Contributor

Summary

Fix Windows backend integration tests that were failing due to missing volume mount symlink support on Windows.

Changes

  • Add #[cfg(windows)] symlink support in setup_volume_mount_paths using std::os::windows::fs::symlink_dir() for both absolute and relative volume targets
  • Use cross-platform WINDMILL_DIR for volume cache base dir instead of hardcoded /tmp/windmill/volume_cache
  • Change test_volume_sql_worker_e2e to use relative volume path (data) instead of absolute (/tmp/data) for cross-platform compatibility
  • Add branch trigger to backend-test-windows.yml for CI on this PR

Test plan


Generated with Claude Code

@windmill-internal-app
Copy link
Contributor

🤖 Updated ee-repo-ref.txt to 06a848ab04e3f43978b92f0ceee019e9e2fe50f1 after windmill-ee-private PR #465 was merged.

@windmill-internal-app windmill-internal-app bot changed the title [ee] fix: windows volume mount symlinks for integration tests fix: windows volume mount symlinks for integration tests Mar 18, 2026
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 18, 2026

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: a1f7d7b
Status:⚡️  Build in progress...

View logs

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@rubenfiszel rubenfiszel force-pushed the fix-windows-integration-tests branch from c97203e to a1f7d7b Compare March 18, 2026 10:27
@rubenfiszel rubenfiszel marked this pull request as ready for review March 18, 2026 10:27
@rubenfiszel rubenfiszel merged commit 997dd6a into main Mar 18, 2026
17 of 18 checks passed
@rubenfiszel rubenfiszel deleted the fix-windows-integration-tests branch March 18, 2026 10:27
@claude
Copy link
Contributor

claude bot commented Mar 18, 2026

Claude Code is working…

I'll analyze this and get back to you.

View job run

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant