Skip to content

nit: truncated icons#8432

Open
diegoimbert wants to merge 1 commit intomainfrom
di/nit-truncated-icons
Open

nit: truncated icons#8432
diegoimbert wants to merge 1 commit intomainfrom
di/nit-truncated-icons

Conversation

@diegoimbert
Copy link
Contributor

No description provided.

@claude
Copy link
Contributor

claude bot commented Mar 18, 2026

Claude finished @diegoimbert's task in 1m 45s —— View job


Review of PR #8432 — nit: truncated icons

  • Gather context and read changes
  • Review code quality and provide feedback

Changes

This PR adds pt-2 (top padding of 0.5rem) to two <div> wrappers around <DisplayResult> in the app editor's runnable job panel (RunnableJobPanelInner.svelte):

  1. Line 42 — the frontendJob branch
  2. Line 46 — the testJob completed/streaming branch

Both divs already had px-1 for horizontal padding; this adds vertical breathing room so icons or content at the top of the result display aren't visually clipped.

Feedback

Looks good. The change is minimal, consistent across both code paths, and addresses a visual truncation issue. No functional, performance, or security concerns.

One minor observation: the third branch (the {:else} fallback at line 57) already uses px-1 pt-1 — so after this change, the result branches use pt-2 while the fallback uses pt-1. This is likely intentional since the fallback contains simpler content (a loader or text), but worth confirming that the visual spacing feels consistent across all three states.

How to reproduce

In the Windmill app editor, add a runnable component (e.g., a script), open its configuration panel, and run a test. Look at the result/output pane — the icons and content at the top of the result display should no longer appear truncated or clipped.

@cloudflare-workers-and-pages
Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e11a44
Status: ✅  Deploy successful!
Preview URL: https://412367f0.windmill.pages.dev
Branch Preview URL: https://di-nit-truncated-icons.windmill.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant