Skip to content

chore: restore backend/.env copy in worktree setup#8452

Merged
rubenfiszel merged 1 commit intomainfrom
restore-backend-env-copy
Mar 19, 2026
Merged

chore: restore backend/.env copy in worktree setup#8452
rubenfiszel merged 1 commit intomainfrom
restore-backend-env-copy

Conversation

@centdix
Copy link
Collaborator

@centdix centdix commented Mar 19, 2026

Summary

  • When .workmux.yaml was removed, the files.copy directive that copied backend/.env into new worktrees was lost
  • Restores the copy in wm_copy_dependencies() in scripts/worktree-common.sh, which runs for both workmux and Claude hooks

Test plan

  • Create a new worktree and verify backend/.env is copied from the main repo

🤖 Generated with Claude Code

@claude
Copy link
Contributor

claude bot commented Mar 19, 2026

Claude finished @centdix's task in 1m 42s —— View job


Review of PR #8452

  • Read the diff and surrounding context
  • Post review feedback

Feedback

LGTM — this is a clean, minimal fix.

The change correctly restores the backend/.env copy that was lost when .workmux.yaml was removed. It follows the exact same pattern as the existing copies in wm_copy_dependencies() (guard with -f/-d, cp, echo confirmation), and placing it first in the function makes sense since the backend env is needed before anything else runs.

No issues found — no bugs, no security concerns, no performance impact.

Reproduction instructions

This change affects the developer worktree setup workflow, not the app UI. To verify: create a new git worktree (e.g. git worktree add ../test-wt some-branch) with a backend/.env in the main repo, then confirm the file is copied into the new worktree's backend/ directory.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 19, 2026

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32bfa69
Status: ✅  Deploy successful!
Preview URL: https://e3d072bc.windmill.pages.dev
Branch Preview URL: https://restore-backend-env-copy.windmill.pages.dev

View logs

@centdix centdix changed the title fix: restore backend/.env copy in worktree setup chore: restore backend/.env copy in worktree setup Mar 19, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@centdix centdix force-pushed the restore-backend-env-copy branch from d229611 to 32bfa69 Compare March 19, 2026 11:42
@rubenfiszel rubenfiszel merged commit 278c8fe into main Mar 19, 2026
2 checks passed
@rubenfiszel rubenfiszel deleted the restore-backend-env-copy branch March 19, 2026 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants