Skip to content

Commit ed6e954

Browse files
committed
update docker docs
1 parent 19520bf commit ed6e954

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

docs/advanced/7_docker/index.mdx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,10 @@ Here an example of a a worker group setup with a dind side-container to be adapt
7979

8080
## Using Windmill native docker support (recommended)
8181

82-
Windmill has a native docker support if the `# docker` annotation is used. It will assume a a docker socket is mounted like in the example above and will take over management of the container as soon as the script ends. Which is why you should use docker `-d` deamon mode so that the bash script terminates early.
82+
Windmill has a native docker support if the `# docker` annotation is used. It will assume a a docker socket is mounted like in the example above and will take over management of the container as soon as the script ends, assuming that the container was ran with the `$WM_JOB_ID` as name.
83+
Which is why you should use docker `-d` deamon mode so that the bash script terminates early.
84+
85+
It will handle memory tracking, logs streaming and the different exit code of the container properly.
8386

8487
The default code is as follows:
8588

@@ -102,7 +105,9 @@ docker run --name $WM_JOB_ID -it -d $IMAGE $COMMAND
102105
```
103106

104107

105-
## Using remote container deamons (not recommended)
108+
## Using remote container runtimes (not recommended)
109+
110+
This method is not recommended because it skips Windmill's native docker runtime and simpl execute as a normal bash script.
106111

107112
### Remote docker deamon (not recommended)
108113

0 commit comments

Comments
 (0)