[fix]: [CCM-30181]: Prevent stale Redis cache from skipping Azure SKU API refresh (#37)

* c24bb1 CCM-30181: Update VMs from Public API rather than cache

* d6efa0 CCM-30181: Update VMs from Public API rather than cache

Author: mulpuri

internal/cloudinfo/providers/azure/cloudinfo.go

@@ -115,15 +115,7 @@ type ResourceSkuRetriever interface {
 
 // NewAzureInfoer creates a new instance of the Azure infoer.
 func NewAzureInfoer(config Config, logger cloudinfo.Logger) (*AzureInfoer, error) {
-	logger.Info("NewAzureInfoer: config received", map[string]interface{}{
-		"configSubscriptionId": config.SubscriptionID,
-		"configTenantId":       config.TenantID,
-		"configClientId":       config.ClientID,
-		"hasClientSecret":      config.ClientSecret != "",
-	})
-
 	var authorizer autorest.Authorizer
-	authSource := "none"
 
 	if config.ClientID != "" && config.ClientSecret != "" && config.TenantID != "" {
 		credentialsConfig := auth.NewClientCredentialsConfig(config.ClientID, config.ClientSecret, config.TenantID)
@@ -133,27 +125,18 @@ func NewAzureInfoer(config Config, logger cloudinfo.Logger) (*AzureInfoer, error
 		}
 
 		authorizer = a
-		authSource = "clientCredentials"
-		logger.Info("NewAzureInfoer: using client credentials auth")
 	}
 
 	if authorizer == nil {
-		logger.Info("NewAzureInfoer: client credentials not available, trying environment auth")
 		a, err := auth.NewAuthorizerFromEnvironment()
 		authorizer = a
 		if err != nil { // Failed to create authorizer from environment, try from file
-			logger.Info("NewAzureInfoer: environment auth failed, trying file auth", map[string]interface{}{
-				"envAuthError": err.Error(),
-			})
 			a, err := auth.NewAuthorizerFromFile(azure.PublicCloud.ResourceManagerEndpoint)
 			if err != nil {
 				return nil, errors.Wrap(err, "failed to get authorizer from both env and file")
 			}
 
 			authorizer = a
-			authSource = "file"
-		} else {
-			authSource = "environment"
 		}
 	}
 
@@ -172,13 +155,6 @@ func NewAzureInfoer(config Config, logger cloudinfo.Logger) (*AzureInfoer, error
 	containerServiceClient := containerservice.NewContainerServicesClient(config.SubscriptionID)
 	containerServiceClient.Authorizer = authorizer
 
-	logger.Info("NewAzureInfoer: initialized", map[string]interface{}{
-		"authSource":     authSource,
-		"subscriptionId": config.SubscriptionID,
-		"tenantId":       config.TenantID,
-		"clientId":       config.ClientID,
-	})
-
 	return &AzureInfoer{
 		subscriptionId:      config.SubscriptionID,
 		subscriptionsClient: sClient,
@@ -603,9 +579,7 @@ func (a *AzureInfoer) GetVirtualMachines(region string) ([]types.VMInfo, error)
 	logger := a.log.WithFields(map[string]interface{}{"region": region})
 	startTime := time.Now()
 
-	logger.Info("GetVirtualMachines: starting SKU API call", map[string]interface{}{
-		"subscriptionId": a.subscriptionId,
-	})
+	logger.Info("GetVirtualMachines: starting SKU API call")
 
 	skusResultPage, err := a.skusClient.List(context.Background())
 	if err != nil {

internal/cloudinfo/scrape.go

@@ -79,12 +79,8 @@ func (sm *scrapingManager) scrapeServiceRegionProducts(ctx context.Context, serv
 	logger := log.WithFields(sm.log, map[string]interface{}{"service": service, "region": regionId})
 
 	logger.Debug("retrieving regional product information")
-	vms, ok := sm.store.GetVm(sm.provider, service, regionId)
-	if !ok {
-		logger.Debug("VMs not yet cached, proceeding to scraping them...")
-	}
-
-	values, err := sm.infoer.GetProducts(vms, service, regionId)
+	// Always fetch fresh VM SKUs from Azure API instead of cache
+	values, err := sm.infoer.GetProducts(nil, service, regionId)
 	if err != nil {
 		return errors.Wrap(err, "failed to retrieve products for region")
 	}