Added support for doubles (#13)

Fixes an issue where casting a double to AST would throw an unimplemented exception

Co-authored-by: Luke Towers <git@luketowers.ca>

Author: jaxwilko

composer.json

@@ -32,5 +32,9 @@
         "psr-4": {
             "Winter\\LaravelConfigWriter\\Tests\\": "tests/"
         }
+    },
+    "scripts": {
+        "stan": "./vendor/bin/phpstan analyse",
+        "test": "./vendor/bin/phpunit"
     }
 }

src/ArrayFile.php

@@ -11,6 +11,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Scalar\String_;
+use PhpParser\Node\Scalar\DNumber;
 use PhpParser\Node\Scalar\LNumber;
 use PhpParser\Node\Stmt;
 use PhpParser\Parser\Php7;
@@ -187,8 +188,8 @@ protected function makeArrayItem(string $key, string $valueType, $value): ArrayI
      * Generate an AST node, using `PhpParser` classes, for a value
      *
      * @param mixed $value
-     * @throws \RuntimeException If $type is not one of 'string', 'boolean', 'integer', 'function', 'const', 'null', or 'array'
-     * @return ConstFetch|LNumber|String_|Array_|FuncCall
+     * @throws \RuntimeException If $type is not one of 'string', 'boolean', 'integer', 'double', 'function', 'const', 'null', or 'array'
+     * @return ConstFetch|LNumber|DNumber|String_|Array_|FuncCall
      */
     protected function makeAstNode(string $type, $value)
     {
@@ -199,6 +200,8 @@ protected function makeAstNode(string $type, $value)
                 return new ConstFetch(new Name($value ? 'true' : 'false'));
             case 'integer':
                 return new LNumber($value);
+            case 'double':
+                return new DNumber($value);
             case 'function':
                 return new FuncCall(
                     new Name($value->getName()),

tests/ArrayFileTest.php

@@ -135,6 +135,15 @@ public function testCasting()
         $this->assertTrue(is_array($result));
         $this->assertArrayHasKey('url', $result);
         $this->assertIsInt($result['url']);
+
+        $arrayFile = ArrayFile::open(__DIR__ . '/fixtures/array/sample-array-file.php');
+        $arrayFile->set('url', 12.34);
+        $result = eval('?>' . $arrayFile->render());
+
+        $this->assertTrue(is_array($result));
+        $this->assertArrayHasKey('url', $result);
+        $this->assertIsFloat($result['url']);
+        $this->assertEquals(12.34, $result['url']);
     }
 
     public function testRender()
@@ -227,6 +236,17 @@ public function testRender()
 
         $this->assertArrayHasKey('aNumber', $result);
         $this->assertEquals(69, $result['aNumber']);
+
+        /*
+         * Rewrite a double/float
+         */
+        $arrayFile = ArrayFile::open(__DIR__ . '/fixtures/array/sample-array-file.php');
+        $arrayFile->set('aNumber', 3.14159);
+        $result = eval('?>' . $arrayFile->render());
+
+        $this->assertArrayHasKey('aNumber', $result);
+        $this->assertIsFloat($result['aNumber']);
+        $this->assertEquals(3.14159, $result['aNumber']);
     }
 
     public function testConfigInvalid()