Merge pull request #6 from wintermute-core/host-path

chore: path validation update

Author: denis256

.github/workflows/main-validation.yml

@@ -60,6 +60,16 @@ jobs:
             exit 1
           fi
 
+      - name: Test missing mountPath detection
+        run: |
+          echo "Testing missing mountPath detection..."
+          if helm template test charts/k8s-service -f charts/k8s-service/tests/missing-mountpath.yaml 2>&1 | grep -q "mountPath.*required"; then
+            echo "✓ Missing mountPath correctly detected and rejected"
+          else
+            echo "✗ FAIL: Missing mountPath was not detected"
+            exit 1
+          fi
+
       - name: Validation complete
         run: |
           echo "✓ Main branch validation passed"
@@ -71,3 +81,4 @@ jobs:
           echo "  - Valid hostPaths test passed"
           echo "  - Duplicate mountPath detection passed"
           echo "  - Duplicate host path detection passed"
+          echo "  - Missing mountPath detection passed"

.github/workflows/pr-validation.yml

@@ -55,6 +55,16 @@ jobs:
             exit 1
           fi
 
+      - name: Test missing mountPath detection
+        run: |
+          echo "Testing missing mountPath detection..."
+          if helm template test charts/k8s-service -f charts/k8s-service/tests/missing-mountpath.yaml 2>&1 | grep -q "mountPath.*required"; then
+            echo "✓ Missing mountPath correctly detected and rejected"
+          else
+            echo "✗ FAIL: Missing mountPath was not detected"
+            exit 1
+          fi
+
       - name: Validation complete
         run: |
           echo "✓ All Helm chart validations passed successfully"
@@ -63,3 +73,4 @@ jobs:
           echo "  - Valid hostPaths test passed"
           echo "  - Duplicate mountPath detection passed"
           echo "  - Duplicate host path detection passed"
+          echo "  - Missing mountPath detection passed"

charts/k8s-service/templates/_deployment_spec.tpl

@@ -473,12 +473,6 @@ spec:
         - name: {{ $name }}
           emptyDir: {}
     {{- end }}
-    {{- range $name, $value := .Values.hostPaths }}
-        - name: {{ $name }}
-          hostPath:
-            path: {{ $value.path }}
-            type: {{ $value.type }}
-    {{- end }}
     {{- /* END VOLUME LOGIC */ -}}
 
     {{- with .Values.nodeSelector }}

charts/k8s-service/templates/_helpers.tpl

@@ -73,23 +73,28 @@ However, due to yaml/json limitations, all the Kubernetes resources require file
 {{- end -}}
 
 {{/*
-Validate hostPaths for duplicate mount paths and host paths.
+Validate hostPaths for required fields and duplicates.
 */}}
 {{- define "k8s-service.validateHostPaths" -}}
   {{- $mountPaths := dict -}}
   {{- $hostPaths := dict -}}
   {{- range $name, $value := .Values.hostPaths -}}
-    {{- if $value.mountPath -}}
-      {{- if hasKey $mountPaths $value.mountPath -}}
-        {{- fail (printf "Duplicate mountPath '%s' found in hostPaths: both '%s' and '%s' use the same mountPath" $value.mountPath (index $mountPaths $value.mountPath) $name) -}}
-      {{- end -}}
-      {{- $_ := set $mountPaths $value.mountPath $name -}}
+    {{- /* Validate required fields */ -}}
+    {{- if not $value.path -}}
+      {{- fail (printf "hostPaths.%s: 'path' is required but not provided" $name) -}}
     {{- end -}}
-    {{- if $value.path -}}
-      {{- if hasKey $hostPaths $value.path -}}
-        {{- fail (printf "Duplicate host path '%s' found in hostPaths: both '%s' and '%s' use the same path" $value.path (index $hostPaths $value.path) $name) -}}
-      {{- end -}}
-      {{- $_ := set $hostPaths $value.path $name -}}
+    {{- if not $value.mountPath -}}
+      {{- fail (printf "hostPaths.%s: 'mountPath' is required but not provided" $name) -}}
     {{- end -}}
+    {{- /* Check for duplicate mountPath */ -}}
+    {{- if hasKey $mountPaths $value.mountPath -}}
+      {{- fail (printf "Duplicate mountPath '%s' found in hostPaths: both '%s' and '%s' use the same mountPath" $value.mountPath (index $mountPaths $value.mountPath) $name) -}}
+    {{- end -}}
+    {{- $_ := set $mountPaths $value.mountPath $name -}}
+    {{- /* Check for duplicate host path */ -}}
+    {{- if hasKey $hostPaths $value.path -}}
+      {{- fail (printf "Duplicate host path '%s' found in hostPaths: both '%s' and '%s' use the same path" $value.path (index $hostPaths $value.path) $name) -}}
+    {{- end -}}
+    {{- $_ := set $hostPaths $value.path $name -}}
   {{- end -}}
 {{- end -}}

charts/k8s-service/tests/README.md

@@ -8,20 +8,24 @@ This directory contains test value files for validating chart behavior.
 
 - `duplicate-mountpath.yaml` - Tests that duplicate `mountPath` values are detected and rejected
 - `duplicate-hostpath.yaml` - Tests that duplicate host `path` values are detected and rejected
+- `missing-mountpath.yaml` - Tests that missing required `mountPath` field is detected and rejected
 
 ### Positive Tests (Should Pass)
 
 - `valid-hostpaths.yaml` - Tests that valid unique hostPaths configuration works correctly
 
 ## Running Tests Locally
 
-### Test that duplicates are rejected:
+### Test that validation catches errors:
 ```bash
 # Should fail with error about duplicate mountPath
 helm template test charts/k8s-service -f charts/k8s-service/tests/duplicate-mountpath.yaml
 
 # Should fail with error about duplicate host path
 helm template test charts/k8s-service -f charts/k8s-service/tests/duplicate-hostpath.yaml
+
+# Should fail with error about required mountPath
+helm template test charts/k8s-service -f charts/k8s-service/tests/missing-mountpath.yaml
 ```
 
 ### Test that valid config works:

charts/k8s-service/tests/missing-mountpath.yaml

@@ -0,0 +1,12 @@
+# Test: Missing mountPath should fail validation
+# This test should FAIL with error about required mountPath
+
+applicationName: test-missing-mountpath
+containerImage:
+  repository: nginx
+  tag: stable
+
+hostPaths:
+  data:
+    path: /host/data
+    # mountPath is missing - should fail!