feat: make public_key the entity id of StoredCredential [WPB-22045]#1653
Merged
SimonThormeyer merged 23 commits intomainfrom Dec 10, 2025
Merged
feat: make public_key the entity id of StoredCredential [WPB-22045]#1653SimonThormeyer merged 23 commits intomainfrom
public_key the entity id of StoredCredential [WPB-22045]#1653SimonThormeyer merged 23 commits intomainfrom
Conversation
132b0d9 to
0cce2e0
Compare
public_key the entity id of StoredCredential [WPB-22045]
e8e7680 to
1c6375a
Compare
istankovic
reviewed
Dec 10, 2025
keystore/src/connection/platform/generic/migrations/V20__credentials_new_primary_key.sql
Outdated
Show resolved
Hide resolved
51f3a1f to
566da2d
Compare
...With `public_key` as primary key.
We're keeping this until the first release after devashishdxt/idb#36 is resolved. Also, remove `indexmap` dependency, because we don't need it anymore.
We don't need it anymore, we have its features on our idb fork now.
Also move it into a place where the author of a new migration is more likely to be reminded to update it.
Here it's still useful.
It's very helpful when debugging wasm tests.
…action We cannot use the regular `Database::open()` because this would result in infinite recursion when used in migrations.
This would result in infinite recursion
566da2d to
62ea1ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
See title
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.