Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
in the current model sqldelight
.asFlow()from select queries will emit an update for any mutaion select that changes any table in the select without control of wither this mutaion need to update the flow of notfor example
the select will update even tho the conversaiton is not related and there is 0 data change for the 'cool_boiz' conv
Causes (Optional)
this is how it works with sqldelight
Solutions
fork sqldelight and add a feature where you can have annotaions in a comment inside the .sq file, those annotaions will resolve to a custom flow listner that follow the annotaions
How it works:
@CustomKeytells a query which keys to listen for@NotifyCustomKeytells a mutation which keys to notify after it runs:conversation_idget resolved from the actual arguments at runtime, soconversation_:conversation_idbecomes something likeconversation_conv123This behavior can be configured at compile time so we can adapt it only in internal apps first
what i am looking for in this PR is to start the conversation if this is something we want to adapt
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.