fix: call service crashing in background (#WPB-17663) (#4028)

Author: sbakhtiarov

app/src/main/kotlin/com/wire/android/notification/CallNotificationManager.kt

@@ -19,8 +19,10 @@
 package com.wire.android.notification
 
 import android.annotation.SuppressLint
+import android.app.ActivityManager
 import android.app.Notification
 import android.content.Context
+import android.os.Build
 import android.service.notification.StatusBarNotification
 import androidx.core.app.NotificationCompat
 import androidx.core.app.NotificationCompat.CallStyle
@@ -63,6 +65,7 @@ class CallNotificationManager @Inject constructor(
 ) {
 
     private val notificationManager = NotificationManagerCompat.from(context)
+    private val activityManager = context.getSystemService(Context.ACTIVITY_SERVICE) as ActivityManager
     private val scope = CoroutineScope(SupervisorJob() + dispatcherProvider.default())
     private val incomingCallsForUsers = MutableStateFlow<Map<UserId, IncomingCallsForUser>>(mapOf())
 
@@ -158,6 +161,23 @@ class CallNotificationManager @Inject constructor(
         notificationManager.notify(tag, id, notification)
     }
 
+    fun areServiceNotificationsEnabled(): Boolean {
+
+        val isBackgroundRestricted = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
+            activityManager.isBackgroundRestricted
+        } else {
+            false
+        }
+
+        return notificationManager.areNotificationsEnabled() && !isBackgroundRestricted
+    }
+
+    fun showNotification(id: NotificationIds, notification: Notification) {
+        if (notificationManager.areNotificationsEnabled()) {
+            notificationManager.notify(id.ordinal, notification)
+        }
+    }
+
     companion object {
         private const val TAG = "CallNotificationManager"
 

app/src/main/kotlin/com/wire/android/services/CallService.kt

@@ -34,15 +34,15 @@ import com.wire.android.notification.NotificationIds
 import com.wire.android.services.CallService.Action
 import com.wire.android.util.dispatchers.DispatcherProvider
 import com.wire.android.util.logIfEmptyUserName
+import com.wire.kalium.common.functional.Either
+import com.wire.kalium.common.functional.fold
 import com.wire.kalium.logic.CoreLogic
 import com.wire.kalium.logic.data.call.CallStatus
 import com.wire.kalium.logic.data.id.ConversationId
 import com.wire.kalium.logic.data.id.QualifiedIdMapper
 import com.wire.kalium.logic.data.user.UserId
 import com.wire.kalium.logic.feature.call.CallsScope
 import com.wire.kalium.logic.feature.session.CurrentSessionResult
-import com.wire.kalium.common.functional.Either
-import com.wire.kalium.common.functional.fold
 import dagger.hilt.android.AndroidEntryPoint
 import dev.ahmedmourad.bundlizer.Bundlizer
 import kotlinx.coroutines.CoroutineScope
@@ -145,7 +145,7 @@ class CallService : Service() {
                                 stopSelf()
                             },
                             { data ->
-                                generateForegroundNotification(data)
+                                updateForegroundNotification(data)
                             }
                         )
                     }
@@ -161,21 +161,19 @@ class CallService : Service() {
         scope.cancel()
     }
 
-    private fun generateForegroundNotification(data: CallNotificationData) {
-        appLogger.i("$TAG: generating foregroundNotification...")
-        val notification = if (data.callStatus == CallStatus.STARTED) {
-            callNotificationManager.builder.getOutgoingCallNotification(data)
-        } else {
-            callNotificationManager.builder.getOngoingCallNotification(data)
-        }
-        ServiceCompat.startForeground(
-            this,
-            NotificationIds.CALL_OUTGOING_ONGOING_NOTIFICATION_ID.ordinal,
-            notification,
-            ServiceInfo.FOREGROUND_SERVICE_TYPE_PHONE_CALL or ServiceInfo.FOREGROUND_SERVICE_TYPE_MICROPHONE
-        )
+    private fun updateForegroundNotification(data: CallNotificationData) {
+        // Updating service notification when notifications are disabled (or background work restricted)
+        // causes app crash when putting app in background
+        if (callNotificationManager.areServiceNotificationsEnabled()) {
 
-        appLogger.i("$TAG: started foreground with proper notification")
+            val notification = if (data.callStatus == CallStatus.STARTED) {
+                callNotificationManager.builder.getOutgoingCallNotification(data)
+            } else {
+                callNotificationManager.builder.getOngoingCallNotification(data)
+            }
+
+            callNotificationManager.showNotification(NotificationIds.CALL_OUTGOING_ONGOING_NOTIFICATION_ID, notification)
+        }
     }
 
     private fun generatePlaceholderForegroundNotification() {

app/src/test/kotlin/com/wire/android/notification/CallNotificationManagerTest.kt

@@ -17,6 +17,7 @@
  */
 package com.wire.android.notification
 
+import android.app.ActivityManager
 import android.app.Notification
 import android.content.Context
 import android.service.notification.StatusBarNotification
@@ -374,6 +375,9 @@ class CallNotificationManagerTest {
         @MockK
         lateinit var notificationManager: NotificationManagerCompat
 
+        @MockK
+        lateinit var activityManager: ActivityManager
+
         @MockK
         lateinit var callNotificationBuilder: CallNotificationBuilder
 
@@ -384,6 +388,7 @@ class CallNotificationManagerTest {
             MockKAnnotations.init(this, relaxUnitFun = true)
             mockkStatic(NotificationManagerCompat::from)
             every { NotificationManagerCompat.from(any()) } returns notificationManager
+            every { context.getSystemService(Context.ACTIVITY_SERVICE) } returns activityManager
             withActiveNotifications(emptyList())
             every { callNotificationBuilder.getIncomingCallNotification(any(), any()) } returns mockk()
             withCurrentSession(AccountInfo.Valid(UserId("userId", "domain")))
@@ -392,6 +397,7 @@ class CallNotificationManagerTest {
         fun clearRecordedCallsForNotificationManager() {
             clearMocks(
                 notificationManager,
+                activityManager,
                 answers = false,
                 recordedCalls = true,
                 childMocks = false,