fix(apps): update copies to allow easier translations management (WPB-21442) (#4422)

Author: yamilmedina

app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/item/SystemMessageItem.kt

@@ -551,20 +551,23 @@ private fun SystemMessage.buildContent() = when (this) {
         iconTintColor = MaterialTheme.wireColorScheme.onBackground,
     ) {
         val markdownTextStyle = DefaultMarkdownTextStyle.copy(normalColor = MaterialTheme.wireColorScheme.primary)
-        val content = stringResource(
-            id = when {
-                isAuthorSelfUser -> R.string.label_system_message_apps_access_changed_by_self
-                else -> R.string.label_system_message_apps_access_changed_by_other
-            },
-            formatArgs = arrayOf(
-                author.asString().markdownBold(),
-                if (isAccessEnabled) {
-                    stringResource(R.string.label_system_message_apps_access_changed_enabled)
+        val contentResId = when {
+            isAccessEnabled -> {
+                if (isAuthorSelfUser) {
+                    R.string.label_system_message_apps_access_enabled_by_self
                 } else {
-                    stringResource(R.string.label_system_message_apps_access_changed_disabled)
+                    R.string.label_system_message_apps_access_enabled_by_other
                 }
-            )
-        )
+            }
+            else -> {
+                if (isAuthorSelfUser) {
+                    R.string.label_system_message_apps_access_disabled_by_self
+                } else {
+                    R.string.label_system_message_apps_access_disabled_by_other
+                }
+            }
+        }
+        val content = stringResource(id = contentResId, formatArgs = arrayOf(author.asString().markdownBold()))
         val footer = stringResource(R.string.label_system_message_apps_access_enabled_disclaimer)
         buildAnnotatedString {
             append(content.toMarkdownAnnotatedString())

app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/preview/PreviewSystemMessageItem.kt

@@ -478,7 +478,7 @@ fun PreviewSystemMessageConversationMessageAppsAccessEnabled() {
         SystemMessageItem(
             message = mockMessageWithKnock.copy(
                 messageContent = UIMessageContent.SystemMessage.ConversationAppsEnabledChanged(
-                    author = UIText.DynamicString("Barbara Cotolina"),
+                    author = UIText.DynamicString("Barbara"),
                     isAuthorSelfUser = true,
                     isAccessEnabled = true
                 )

app/src/main/res/values/strings.xml

@@ -624,9 +624,9 @@
     <string name="conversation_details_options_tab">OPTIONS</string>
     <string name="conversation_details_participants_tab">PARTICIPANTS</string>
     <string name="conversation_details_options_group_name">GROUP NAME</string>
-    <string name="conversation_details_conversation_admins">CONVERSATION ADMINS (%d)</string>
-    <string name="conversation_details_conversation_members">CONVERSATION MEMBERS (%d)</string>
-    <string name="conversation_details_conversation_apps">CONVERSATION APPS (%d)</string>
+    <string name="conversation_details_conversation_admins">ADMINS (%d)</string>
+    <string name="conversation_details_conversation_members">MEMBERS (%d)</string>
+    <string name="conversation_details_conversation_apps">APPS (%d)</string>
     <string name="conversation_details_participants_info">This conversation has %s participants.\nUp to 500 people can join a conversation.</string>
     <string name="conversation_details_participants_count">%s participants</string>
     <string name="conversation_details_show_all_participants">Show all participants (%d)</string>
@@ -1905,9 +1905,9 @@ In group conversations, the group admin can overwrite this setting.</string>
     <string name="search_results_apps_empty_description_non_team_admin">Apps are helpers that can improve your workflow. To use them, ask your team admin.</string>
     <string name="search_results_apps_empty_description_disabled_for_conversation">Apps are disabled in this conversation. Enable them in the conversation options.</string>
 
-    <string name="label_system_message_apps_access_changed_enabled">enabled</string>
-    <string name="label_system_message_apps_access_changed_disabled">disabled</string>
-    <string name="label_system_message_apps_access_changed_by_self">%1$s %2$s **apps** for this conversation</string>
-    <string name="label_system_message_apps_access_changed_by_other">%1$s %2$s **apps** for this conversation</string>
+    <string name="label_system_message_apps_access_enabled_by_self">%1$s enabled **apps** for this conversation</string>
+    <string name="label_system_message_apps_access_disabled_by_self">%1$s disabled **apps** for this conversation</string>
+    <string name="label_system_message_apps_access_enabled_by_other">%1$s enabled **apps** for this conversation</string>
+    <string name="label_system_message_apps_access_disabled_by_other">%1$s disabled **apps** for this conversation</string>
     <string name="label_system_message_apps_access_enabled_disclaimer">Added apps have access to the content of this conversation.</string>
 </resources>