fix(apps): consider protocol instead of feature flag for enabling apps interaction (WPB-21835) (#4428)

Author: yamilmedina

app/src/main/kotlin/com/wire/android/ui/home/conversations/details/GroupConversationDetailsViewModel.kt

@@ -80,7 +80,7 @@ class GroupConversationDetailsViewModel @Inject constructor(
     private val isMLSEnabled: IsMLSEnabledUseCase,
     refreshUsersWithoutMetadata: RefreshUsersWithoutMetadataUseCase,
     private val isWireCellsEnabled: IsWireCellsEnabledUseCase,
-    private val observeIsAppsAllowedForUsage: ObserveIsAppsAllowedForUsageUseCase,
+    private val observeIsAppsAllowedForUsage: ObserveIsAppsAllowedForUsageUseCase
 ) : GroupConversationParticipantsViewModel(savedStateHandle, observeConversationMembers, refreshUsersWithoutMetadata),
     ActionsManager<GroupConversationDetailsViewAction> by ActionsManagerImpl() {
 
@@ -132,6 +132,10 @@ class GroupConversationDetailsViewModel @Inject constructor(
                 val channelPermissionType = groupDetails.getChannelPermissionType()
                 val channelAccessType = groupDetails.getChannelAccessType()
 
+                // todo: WPB-21835: ignoring feature flag, and based on protocol until there is finalized apps support.
+                // isAppsUsageAllowed should be consider then.
+                val isMLSConversation = groupDetails.conversation.protocol is Conversation.ProtocolInfo.MLS
+
                 _isFetchingInitialData.value = false
 
                 updateState(
@@ -146,8 +150,8 @@ class GroupConversationDetailsViewModel @Inject constructor(
                         isUpdatingNameAllowed = canSelfPerformAdminTasks && !isSelfExternalMember,
                         isUpdatingGuestAllowed = canSelfPerformAdminTasks && isSelfInTeamThatOwnsConversation,
                         isUpdatingChannelAccessAllowed = canSelfPerformAdminTasks && isSelfInTeamThatOwnsConversation,
-                        isServicesAllowed = groupDetails.conversation.isServicesAllowed() && isAppsUsageAllowed,
-                        isUpdatingServicesAllowed = canSelfPerformAdminTasks && isAppsUsageAllowed,
+                        isServicesAllowed = groupDetails.conversation.isServicesAllowed() && !isMLSConversation,
+                        isUpdatingServicesAllowed = canSelfPerformAdminTasks && isSelfInTeamThatOwnsConversation && !isMLSConversation,
                         isUpdatingReadReceiptAllowed = canSelfPerformAdminTasks && groupDetails.conversation.isTeamGroup(),
                         isUpdatingSelfDeletingAllowed = canSelfPerformAdminTasks,
                         mlsEnabled = isMLSEnabled(),

app/src/main/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModel.kt

@@ -66,7 +66,7 @@ class NewConversationViewModel @Inject constructor(
     private val getSelfUser: GetSelfUserUseCase,
     private val getDefaultProtocol: GetDefaultProtocolUseCase,
     private val isWireCellsFeatureEnabled: IsWireCellsEnabledUseCase,
-    private val observeIsAppsAllowedForUsage: ObserveIsAppsAllowedForUsageUseCase
+    private val observeIsAppsAllowedForUsage: ObserveIsAppsAllowedForUsageUseCase,
 ) : ViewModel() {
 
     var newGroupNameTextState: TextFieldState = TextFieldState()
@@ -96,9 +96,11 @@ class NewConversationViewModel @Inject constructor(
         viewModelScope.launch {
             observeIsAppsAllowedForUsage()
                 .collectLatest { appsAllowed ->
+                    // todo: WPB-21835: ignoring feature flag, and based on protocol until there is finalized apps support.
+                    val isMLS = newGroupState.groupProtocol == CreateConversationParam.Protocol.MLS
                     groupOptionsState = groupOptionsState.copy(
-                        isTeamAllowedToUseApps = appsAllowed,
-                        isAllowAppsEnabled = appsAllowed
+                        isTeamAllowedToUseApps = !isMLS,
+                        isAllowAppsEnabled = !isMLS
                     )
                 }
         }

app/src/test/kotlin/com/wire/android/ui/home/newconversation/NewConversationViewModelTest.kt

@@ -366,15 +366,15 @@ class NewConversationViewModelTest {
     }
 
     @Test
-    fun `given apps are not allowed, when initializing viewModel, then state should reflect that`() = runTest {
+    fun `given apps are not allowed, when initializing, then state should ignore the feature flag and based on protocol`() = runTest {
         // Given
         val (_, viewModel) = NewConversationViewModelArrangement()
             .withGetSelfUser(isTeamMember = true)
             .withAppsAllowedResult(false)
             .arrange()
 
-        assertFalse(viewModel.groupOptionsState.isTeamAllowedToUseApps)
-        assertFalse(viewModel.groupOptionsState.isAllowAppsEnabled)
+        assertTrue(viewModel.groupOptionsState.isTeamAllowedToUseApps)
+        assertTrue(viewModel.groupOptionsState.isAllowAppsEnabled)
     }
 
     @Test