-
Notifications
You must be signed in to change notification settings - Fork 45
feat: add dynamic accent color system and dark mode improvements [WPB-21145] #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
|
@Garzas looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (72.22%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4393 +/- ##
===========================================
+ Coverage 47.20% 47.24% +0.04%
===========================================
Files 530 530
Lines 17597 17607 +10
Branches 2987 2986 -1
===========================================
+ Hits 8306 8318 +12
+ Misses 8403 8401 -2
Partials 888 888
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| LocalActivity provides this | ||
| ) { | ||
| WireTheme { | ||
| WireTheme(accent = viewModel.globalAppState.userAccent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM
app/src/main/kotlin/com/wire/android/ui/home/conversations/messages/item/MessageBubbleItem.kt
Outdated
Show resolved
Hide resolved
core/ui-common/src/main/kotlin/com/wire/android/ui/theme/WireColorScheme.kt
Outdated
Show resolved
Hide resolved
|



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
This PR introduces dynamic accent color handling and dark mode improvements across the theming system.
Previously, accent colors were resolved manually per component (e.g. via getOrDefault), and UI elements like message bubbles didn’t adapt correctly between light and dark themes.
Causes
WireColorSchemeTypesprovided static base schemes (LightWireColorScheme,DarkWireColorScheme) without dynamic accent mapping.Solutions
Introduced a new Accent & Tone system:
Toneenum (T50–T900) for shade intensity.ShadesandAccentSwatchmodels for light/dark accent palettes.Accent.asSwatch()to resolve the correct palette per theme mode.Enabled dynamic accent application in
WireTheme:LocalWireAccentfor providing accent context.WireThemenow applies accents viawithAccent(accent)usingWireColorScheme.copy().Updated WireColorScheme:
primary,highlight,focus, and status colors (error,warning,positive).Improved dark mode conversation UI:
accent_color_theme.mp4