feat: cover VersionHistoryViewModel with unit test (WPB-21661) #4473
+412
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # features/cells/src/main/res/values/strings.xml # kalium
…node-versions # Conflicts: # kalium
…node-versions # Conflicts: # features/cells/src/main/res/values/strings.xml
…node-versions # Conflicts: # kalium
…node-versions # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/res/values/strings.xml
# Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # core/ui-common/src/main/res/values/strings.xml # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/res/values/strings.xml # kalium
…node-versions # Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/CellsModule.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/res/values/strings.xml # features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/publiclink/PublicLinkViewModelTest.kt # kalium
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
ohassine
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4473 +/- ##
===========================================
+ Coverage 48.43% 48.72% +0.28%
===========================================
Files 563 563
Lines 19464 19466 +2
Branches 3246 3247 +1
===========================================
+ Hits 9428 9485 +57
+ Misses 9045 8985 -60
- Partials 991 996 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sbakhtiarov
approved these changes
Dec 19, 2025
…t' into versionHistoryViewModel-unit-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Covering VersionHistoryViewModel with unit test
This PR contains changes from #4469
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.