-
Notifications
You must be signed in to change notification settings - Fork 45
fix: inform AVS about background state [WPB-21348] #4491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@saleniuk looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4491 +/- ##
===========================================
- Coverage 48.73% 48.70% -0.03%
===========================================
Files 563 563
Lines 19493 19503 +10
Branches 3252 3252
===========================================
Hits 9499 9499
- Misses 8997 9007 +10
Partials 997 997
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The app can receive multiple "missed call" messages even for calls that are still ongoing.
Causes (Optional)
When the app is not receiving CONFCHECK messages on an ongoing basis, for instance due to app not having internet connection, then AVS may timeout that call when going back to online and connection is being reestablished and result in executing onCloseCall event for that call even if the call is still ongoing and that client is not taking part in that call.
Solutions
Implemented the logic to inform the AVS about app being in the background and not keeping the connection alive, so that it can properly determine the current state and decide whether it should timeout because of missing CONFCHECK messages or if it's kind of expected behavior because the app is in the background and not in that call.
In Android code it required passing the info about app being in the background to the kalium which also checks the connection state and gives a proper info to the AVS.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Start a call on another device, don't join a call on current Android device but close the app and turn off the connection (airplane mode), turn it on after a few minutes and open the app again. There should be no "missed call" for that still ongoing call.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.