Skip to content

Conversation

@saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Dec 18, 2025

BugWPB-21348 [Calling] [Android] Multiple Calling Events shown while call is ongoing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The app can receive multiple "missed call" messages even for calls that are still ongoing.

Causes (Optional)

When the app is not receiving CONFCHECK messages on an ongoing basis, for instance due to app not having internet connection, then AVS may timeout that call when going back to online and connection is being reestablished and result in executing onCloseCall event for that call even if the call is still ongoing and that client is not taking part in that call.

Solutions

Implemented the logic to inform the AVS about app being in the background and not keeping the connection alive, so that it can properly determine the current state and decide whether it should timeout because of missing CONFCHECK messages or if it's kind of expected behavior because the app is in the background and not in that call.
In Android code it required passing the info about app being in the background to the kalium which also checks the connection state and gives a proper info to the AVS.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Start a call on another device, don't join a call on current Android device but close the app and turn off the connection (airplane mode), turn it on after a few minutes and open the app again. There should be no "missed call" for that still ongoing call.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
c15237a855f52138ad00746b34285efd6cf6725f 089c7ad8739dea059e9c496eb65674b59df084e3

Is this intentional?

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.70%. Comparing base (7541389) to head (8ebed42).

Files with missing lines Patch % Lines
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% 11 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4491      +/-   ##
===========================================
- Coverage    48.73%   48.70%   -0.03%     
===========================================
  Files          563      563              
  Lines        19493    19503      +10     
  Branches      3252     3252              
===========================================
  Hits          9499     9499              
- Misses        8997     9007      +10     
  Partials       997      997              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7541389...8ebed42. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saleniuk saleniuk requested a review from yamilmedina December 29, 2025 08:52
@sonarqubecloud
Copy link

@saleniuk saleniuk added this pull request to the merge queue Dec 29, 2025
Merged via the queue into develop with commit cb0d517 Dec 29, 2025
16 of 17 checks passed
@saleniuk saleniuk deleted the fix/avs-set-background branch December 29, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants