Skip to content

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Dec 22, 2025

TaskWPB-22250 [Kalium] Cleanup current logic module for api


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Adapt android changes to kalium refactor on

Solutions

  • As logic now is hiding properly internals, adjust code that was using internal implementations of :kalium:logic.

Testing

Test Coverage (Optional)

Current test coverage is enough

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title refactor: making logic api first by using explicitApi (WPB-22250) refactor: adjust android consumer to logic api first using explicitApi (WPB-22250) Dec 22, 2025
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.73%. Comparing base (dd53d88) to head (597d880).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...kmanager/worker/DeleteConversationLocallyWorker.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4495   +/-   ##
========================================
  Coverage    48.72%   48.73%           
========================================
  Files          563      563           
  Lines        19490    19493    +3     
  Branches      3252     3252           
========================================
+ Hits          9496     9499    +3     
  Misses        8997     8997           
  Partials       997      997           
Files with missing lines Coverage Δ
.../messagecomposer/recordaudio/AudioMediaRecorder.kt 0.00% <ø> (ø)
...om/wire/android/util/deeplink/DeepLinkProcessor.kt 75.93% <100.00%> (ø)
...com/wire/android/util/deeplink/UserLinkQRMapper.kt 47.05% <100.00%> (ø)
...ire/android/util/lifecycle/SyncLifecycleManager.kt 96.96% <100.00%> (+0.30%) ⬆️
...com/wire/android/util/ui/WireSessionImageLoader.kt 0.00% <ø> (ø)
...kmanager/worker/DeleteConversationLocallyWorker.kt 1.96% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd53d88...597d880. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@yamilmedina yamilmedina added this pull request to the merge queue Dec 23, 2025
Merged via the queue into develop with commit ab63f47 Dec 23, 2025
16 of 17 checks passed
@yamilmedina yamilmedina deleted the yamil/refactor/apify-logic branch December 23, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants