feat: update and refactoring for move to folder feature (WPB-21155)#4410
feat: update and refactoring for move to folder feature (WPB-21155)#4410sbakhtiarov merged 2 commits intodevelopfrom
Conversation
|
ohassine
left a comment
There was a problem hiding this comment.
tbh, I’m not a fan of sending navigation actions through the ViewModel. I feel like we’re overcomplicating things, when it would be much easier and cleaner for reading to just call the navigate command directly from the UI instead of going through the ViewModel and sending the action back.
I also like to keep ViewModels focused on business logic rather than UI stuff like navigation. Otherwise, it can start to feel like we’re mixing responsibilities and adding extra boilerplate.
| sealed interface MoveToFolderViewAction { | ||
| data object Success : MoveToFolderViewAction | ||
| data object Failure : MoveToFolderViewAction | ||
| data class NavigateToBreadcrumb(val steps: Int) : MoveToFolderViewAction |
There was a problem hiding this comment.
The name NavigateToBreadcrumb might be a bit confusing, how about NavigateThroughBreadcrumb ?



https://wearezeta.atlassian.net/browse/WPB-21155
What's new in this PR?
Updating logic and refactoring the Move To Folder feature screen.
Refactoring:
https://www.figma.com/design/grnVU2vAihHXwYgHryu2xE/Cells---Files?node-id=9021-421573&t=OtIBYIZDGP1jX71t-0