Skip to content

Commit 13919ac

Browse files
chore: update github action notify on Wire - WPB-24093 🍒 (#4469)
Co-authored-by: François Benaiteau <netbe@users.noreply.github.com>
1 parent a5e6f38 commit 13919ac

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

‎.github/workflows/_reusable_run_tests.yml‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ on:
1919
run_critical_flows:
2020
type: boolean
2121
required: true
22+
notify:
23+
type: string
24+
required: true
25+
default: 'failure' # values: always | failure | never
26+
2227
secrets:
2328
ZENKINS_USERNAME:
2429
required: true
@@ -267,10 +272,10 @@ jobs:
267272
echo "commit_sha=$(git rev-parse HEAD)" >> $GITHUB_ENV
268273
echo "commit_message=$(git log -1 --pretty=format:"%s")" >> $GITHUB_ENV
269274
270-
- name: Notify on Wire for iOS Nightly 🤖
275+
- name: Always Notify on Wire
271276
uses: 8398a7/action-slack@v3
272277
continue-on-error: true
273-
if: ${{ inputs.all && always() }}
278+
if: ${{ inputs.notify == 'always' && always() }}
274279
with:
275280
status: ${{ job.status }}
276281
text: |
@@ -281,10 +286,10 @@ jobs:
281286
**Triggered by:** ${{ github.triggering_actor }}
282287
**Build log:** ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
283288
284-
- name: Notify on Wire for iOS CI
289+
- name: Only Notify on Wire failures
285290
uses: 8398a7/action-slack@v3
286291
continue-on-error: true
287-
if: ${{ !inputs.all && failure() }}
292+
if: ${{ inputs.notify == 'failure' && failure() }}
288293
with:
289294
status: ${{ job.status }}
290295
text: |

‎.github/workflows/critical_flows.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@ jobs:
2121
notify_secret: WIRE_IOS_QA_WEBHOOK
2222
test_dependencies: false
2323
run_critical_flows: true
24+
notify: always
2425
secrets: inherit

‎.github/workflows/run_all_tests.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,5 @@ jobs:
1414
all: true
1515
notify_secret: WIRE_IOS_CI_WEBHOOK
1616
run_critical_flows: true
17+
notify: always
1718
secrets: inherit

‎.github/workflows/test_develop.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@ jobs:
2121
branch: ${{ matrix.branch }}
2222
notify_secret: WIRE_IOS_NIGHTLY_WEBHOOK
2323
run_critical_flows: true
24+
notify: always
2425
secrets: inherit

‎.github/workflows/test_pr_changes.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,4 +103,5 @@ jobs:
103103
notify_secret: WIRE_IOS_CI_WEBHOOK
104104
test_dependencies: ${{ github.event_name != 'pull_request' || startsWith(github.base_ref, 'release/cycle') }} # run on merge_queue or release branch PRs
105105
run_critical_flows: false # separare workflow
106+
notify: failure
106107
secrets: inherit

0 commit comments

Comments
 (0)