Skip to content

Commit 6071987

Browse files
chore: update github action notify on Wire - WPB-24093 🍒 (#4474)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: François Benaiteau <netbe@users.noreply.github.com>
1 parent 079e2bb commit 6071987

File tree

5 files changed

+14
-5
lines changed

5 files changed

+14
-5
lines changed

‎.github/workflows/_reusable_run_tests.yml‎

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ on:
2323
type: string
2424
required: false
2525
default: ''
26+
notify:
27+
type: string
28+
required: true
29+
default: 'failure' # values: always | failure | never
30+
2631
secrets:
2732
ZENKINS_USERNAME:
2833
required: true
@@ -297,10 +302,10 @@ jobs:
297302
echo "commit_sha=$(git rev-parse HEAD)" >> $GITHUB_ENV
298303
echo "commit_message=$(git log -1 --pretty=format:"%s")" >> $GITHUB_ENV
299304
300-
- name: Notify on Wire for iOS Nightly 🤖
305+
- name: Always Notify on Wire
301306
uses: 8398a7/action-slack@v3
302307
continue-on-error: true
303-
if: ${{ inputs.all && always() }}
308+
if: ${{ inputs.notify == 'always' && always() }}
304309
with:
305310
status: ${{ job.status }}
306311
text: |
@@ -310,11 +315,11 @@ jobs:
310315
**Commit:** [${{ env.commit_sha }}](https://github.com/wireapp/wire-ios-mono/commit/${{ env.commit_sha }})
311316
**Triggered by:** ${{ github.triggering_actor }}
312317
**Build log:** ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
313-
314-
- name: Notify on Wire for iOS CI
318+
319+
- name: Only Notify on Wire failures
315320
uses: 8398a7/action-slack@v3
316321
continue-on-error: true
317-
if: ${{ !inputs.all && failure() }}
322+
if: ${{ inputs.notify == 'failure' && failure() }}
318323
with:
319324
status: ${{ job.status }}
320325
text: |

‎.github/workflows/critical_flows.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,5 @@ jobs:
2727
test_dependencies: false
2828
run_critical_flows: true
2929
testiny_run_name: ${{ inputs.testiny_run_name }}
30+
notify: always
3031
secrets: inherit

‎.github/workflows/run_all_tests.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,5 @@ jobs:
1414
all: true
1515
notify_secret: WIRE_IOS_CI_WEBHOOK
1616
run_critical_flows: true
17+
notify: always
1718
secrets: inherit

‎.github/workflows/test_develop.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@ jobs:
2121
branch: ${{ matrix.branch }}
2222
notify_secret: WIRE_IOS_NIGHTLY_WEBHOOK
2323
run_critical_flows: true
24+
notify: always
2425
secrets: inherit

‎.github/workflows/test_pr_changes.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,4 +103,5 @@ jobs:
103103
notify_secret: WIRE_IOS_CI_WEBHOOK
104104
test_dependencies: ${{ github.event_name != 'pull_request' || startsWith(github.base_ref, 'release/cycle') }} # run on merge_queue or release branch PRs
105105
run_critical_flows: false # separare workflow
106+
notify: failure
106107
secrets: inherit

0 commit comments

Comments
 (0)