pr feedbacks

Author: findms

WireNetwork/Sources/WireNetwork/APIs/Rest/AuthenticationAPI/AuthenticationAPIV0.swift

@@ -270,11 +270,12 @@ class AuthenticationAPIV0: AuthenticationAPI, VersionedAPI {
             .withBody(body, contentType: .json)
             .build()
 
-        let (_, _) = try await networkService.executeRequest(request)
+        let (_, response) = try await networkService.executeRequest(request)
 
-        _ = ResponseParser()
+        try ResponseParser()
             .success(code: .ok)
             .failure(code: .badRequest, label: "bad-request", error: AuthenticationAPIError.invalidEmail)
+            .parse(code: response.statusCode, data: nil)
     }
 
     func requestEmailVerificationCode(for email: String) async throws {

wire-ios/WireUITests/Pages/AccountSettingsPage.swift

@@ -115,7 +115,7 @@ class AccountSettingsPage: PageModel {
     }
 
     func goBackToSettingsPage() throws -> SettingsPage {
-        if app.onPad() {
+        if app.iPadOnly() {
             return try SettingsPage()
         }
         backToSettingsButton.tap()

wire-ios/WireUITests/Pages/ActiveConversationPage .swift

@@ -77,7 +77,7 @@ class ActiveConversationPage: PageModel {
         // Revert this temporary workaround once WPB-17997 is fixed
         // See: https://wearezeta.atlassian.net/browse/WPB-17997
         let hideKeyboard = app.buttons["Hide keyboard"]
-        app.onPad {
+        app.iPadOnly {
             hideKeyboard.tap()
         }
         return self

wire-ios/WireUITests/Pages/BackupOrRestorePage.swift

@@ -60,7 +60,7 @@ class BackupOrRestorePage: PageModel {
     }
 
     private func sortFiles() {
-        if app.onPad() {
+        if app.iPadOnly() {
             return
         }
         if !browseButtonOnBottom.isSelected {

wire-ios/WireUITests/Pages/ConversationsPage.swift

@@ -61,7 +61,7 @@ class ConversationsPage: PageModel {
     }
 
     func openSettings() throws -> SettingsPage {
-        app.onPad {
+        app.iPadOnly {
             if self.sideBarPanel.exists {
                 self.sideBarPanel.tap()
             }
@@ -71,7 +71,7 @@ class ConversationsPage: PageModel {
     }
 
     func openUserAccountPageForUser(with input: String) throws -> UserAccountPage {
-        app.onPad {
+        app.iPadOnly {
             if self.sideBarPanel.exists {
                 self.sideBarPanel.tap()
             }
@@ -85,7 +85,7 @@ class ConversationsPage: PageModel {
     }
 
     func tapPlusButtonToCreateGroup() throws -> NewConversationPage {
-        app.onPad {
+        app.iPadOnly {
             if self.sidePanel.exists {
                 self.sidePanel.tap()
             }
@@ -95,7 +95,7 @@ class ConversationsPage: PageModel {
     }
 
     func openPendingRequest() throws -> ConnectionRequestsPage {
-        app.onPad {
+        app.iPadOnly {
             if self.sidePanel.exists {
                 self.sidePanel.tap()
             }
@@ -115,7 +115,7 @@ class ConversationsPage: PageModel {
     }
 
     func openConversation() throws -> ActiveConversationPage {
-        app.onPad {
+        app.iPadOnly {
             if self.sidePanel.exists {
                 self.sidePanel.tap()
             }
@@ -146,7 +146,7 @@ class ConversationsPage: PageModel {
     }
 
     func getNameLabel() -> String? {
-        app.onPad {
+        app.iPadOnly {
             if self.sidePanel.exists {
                 self.sidePanel.tap()
             }

wire-ios/WireUITests/Pages/SettingsPage.swift

@@ -59,9 +59,14 @@ class SettingsPage: PageModel {
         if conversationsTab.exists {
             conversationsTab.tap()
         } else {
-            app.onPad { [self] in
-                if sideBarPanel.exists { sideBarPanel.tap() }
-                if allConversations.exists { allConversations.tap() }
+            app.iPadOnly { [self] in
+                if sideBarPanel.exists {
+                    sideBarPanel.tap()
+                }
+
+                if allConversations.exists {
+                    allConversations.tap()
+                }
             }
         }
         return try ConversationsPage()

wire-ios/WireUITests/XCUIApplication+Additions.swift

@@ -37,7 +37,7 @@ extension XCUIApplication {
     }
 
     @discardableResult
-    func onPad(_ block: (() -> Void)? = nil) -> Bool {
+    func iPadOnly(_ block: (() -> Void)? = nil) -> Bool {
         guard UIDevice.current.userInterfaceIdiom == .pad else { return false }
         block?()
         return true