fix: don't reset federated conversations - WPB-22499 🍒 (#4048)

Author: johnxnguyen

WireDomain/Sources/WireDomain/Components/ClientSessionComponent.swift

@@ -811,7 +811,8 @@ public final class ClientSessionComponent {
         mlsService: mlsService,
         conversationLocalStore: conversationLocalStore,
         conversationRepository: conversationRepository,
-        lockRepository: resetMLSConversationLockRepository
+        lockRepository: resetMLSConversationLockRepository,
+        selfDomain: backendMetadata.domain
     )
 
     public lazy var mlsTransport: any WireCoreCryptoUniffi.MlsTransport = MLSTransportImpl(

WireDomain/Sources/WireDomain/Helpers/InitiateResetMLSConversationUseCase.swift

@@ -37,34 +37,49 @@ public class InitiateResetMLSConversationUseCase: InitiateResetMLSConversationUs
     private let conversationLocalStore: ConversationLocalStoreProtocol
     private let conversationRepository: ConversationRepositoryProtocol
     private let lockRepository: ResetMLSConversationLockRepositoryProtocol
+    private let selfDomain: String?
 
     public init(
         api: MLSAPI,
         mlsService: MLSServiceInterface,
         conversationLocalStore: ConversationLocalStoreProtocol,
         conversationRepository: ConversationRepositoryProtocol,
-        lockRepository: ResetMLSConversationLockRepositoryProtocol
+        lockRepository: ResetMLSConversationLockRepositoryProtocol,
+        selfDomain: String?
     ) {
         self.api = api
         self.mlsService = mlsService
         self.conversationLocalStore = conversationLocalStore
         self.conversationRepository = conversationRepository
         self.lockRepository = lockRepository
+        self.selfDomain = selfDomain
     }
 
-    public func invoke(groupID: WireDataModel.MLSGroupID, epoch: UInt64) async {
-
+    public func invoke(
+        groupID: WireDataModel.MLSGroupID,
+        epoch: UInt64
+    ) async {
         var attributes: LogAttributes = [:]
 
         do {
+            guard let selfDomain else {
+                WireLogger.mls.error("Can't initiate reset broken MLS conversation failed: self domain unknown")
+                return
+            }
 
-            guard let conversation = await conversationLocalStore.fetchMLSConversation(groupID: groupID),
-                  let qualifiedID = await conversationLocalStore.qualifiedID(for: conversation)
+            guard
+                let conversation = await conversationLocalStore.fetchMLSConversation(groupID: groupID),
+                let qualifiedID = await conversationLocalStore.qualifiedID(for: conversation)
             else {
                 WireLogger.mls.error("Initiate reset broken MLS conversation failed: no conversation found")
                 return
             }
 
+            guard qualifiedID.domain == selfDomain else {
+                WireLogger.mls.warn("Can't initiate reset broken MLS conversation for other domains")
+                return
+            }
+
             attributes = [
                 .public: true,
                 .conversationId: qualifiedID.safeForLoggingDescription,

WireDomain/Tests/WireDomainTests/UseCases/InitiateResetMLSConversationUseCaseTests.swift

@@ -75,7 +75,8 @@ final class InitiateResetMLSConversationUseCaseTests: XCTestCase {
             mlsService: mockMLSService,
             conversationLocalStore: mockConversationLocalStore,
             conversationRepository: mockConversationRepository,
-            lockRepository: mockResetLockRepository
+            lockRepository: mockResetLockRepository,
+            selfDomain: conversationID.domain
         )
     }
 
@@ -120,4 +121,25 @@ final class InitiateResetMLSConversationUseCaseTests: XCTestCase {
         XCTAssertEqual(mockResetLockRepository.setInitiatedResetConversationID_Invocations.count, 0)
     }
 
+    func testInvoke_DoNothing_WhenConversationDomainIsNotSelfDomain() async {
+
+        // Given - conversation with different domain
+        let otherDomain = "other.example.com"
+        let otherDomainConversationID = QualifiedID(uuid: conversationID.uuid, domain: otherDomain)
+        mockConversationLocalStore.qualifiedIDFor_MockValue = otherDomainConversationID
+
+        let groupID = MLSGroupID.random()
+        // When
+        await sut.invoke(groupID: groupID, epoch: 99)
+
+        // Then
+        XCTAssertEqual(mockConversationLocalStore.fetchMLSConversationGroupID_Invocations.count, 1)
+        XCTAssertEqual(mockConversationLocalStore.qualifiedIDFor_Invocations.count, 1)
+        XCTAssertEqual(mockAPI.resetMLSConversationEpochGroupID_Invocations.count, 0)
+        XCTAssertEqual(mockMLSService.wipeGroup_Invocations.count, 0)
+        XCTAssertEqual(mockMLSService.establishPendingGroupGroupID_Invocations.count, 0)
+        XCTAssertEqual(mockResetLockRepository.setInitiatedResetConversationID_Invocations.count, 0)
+        XCTAssertEqual(mockConversationRepository.pullConversationIdDomain_Invocations.count, 0)
+    }
+
 }

wire-ios-sync-engine/Source/UserSession/ZMUserSession/ZMUserSession.swift

@@ -1355,7 +1355,8 @@ extension ZMUserSession: SyncAgentDelegate {
             conversationRepository: clientSessionComponent.conversationRepository,
             lockRepository: ResetMLSConversationLockRepository(
                 userID: userId
-            )
+            ),
+            selfDomain: resolvedBackendMetadata.domain
         )
     }