Skip to content

Commit 4b933ac

Browse files
authored
feat: add aria labels for microphone and camera options in video controls (#19957)
1 parent 3a44242 commit 4b933ac

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

src/i18n/en-US.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2010,13 +2010,16 @@
20102010
"videoCallOverlayCamera": "Camera",
20112011
"videoCallOverlayChangeViewMode": "Change view mode",
20122012
"videoCallOverlayCloseFullScreen": "Go back to minimized view",
2013+
"videoCallOverlayCloseOptions": "Close options",
20132014
"videoCallOverlayConversations": "Conversations",
20142015
"videoCallOverlayFitVideoLabel": "Double-click to view full screen",
20152016
"videoCallOverlayFitVideoLabelGoBack": "Double-click to show all participants",
20162017
"videoCallOverlayHangUp": "Hang Up",
20172018
"videoCallOverlayHideParticipantsList": "Hide participants list",
20182019
"videoCallOverlayMicrophone": "Microphone",
2020+
"videoCallOverlayOpenCameraOptions": "Open camera options",
20192021
"videoCallOverlayOpenFullScreen": "Open the call in full screen",
2022+
"videoCallOverlayOpenMicrophoneAndSpeakerOptions": "Open microphone and speaker options",
20202023
"videoCallOverlayOpenPopupWindow": "Open in a new window",
20212024
"videoCallOverlayParticipantsListCloseButton": "Hide participants",
20222025
"videoCallOverlayParticipantsListLabel": "Participants ({count})",

src/script/components/calling/VideoControls/VideoControls.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -543,6 +543,11 @@ export const VideoControls = ({
543543
setAudioOptionsOpen(false);
544544
}
545545
}}
546+
aria-label={
547+
audioOptionsOpen
548+
? t('videoCallOverlayCloseOptions')
549+
: t('videoCallOverlayOpenMicrophoneAndSpeakerOptions')
550+
}
546551
>
547552
{audioOptionsOpen ? (
548553
<>
@@ -613,6 +618,9 @@ export const VideoControls = ({
613618
setVideoOptionsOpen(false);
614619
}
615620
}}
621+
aria-label={
622+
videoOptionsOpen ? t('videoCallOverlayCloseOptions') : t('videoCallOverlayOpenCameraOptions')
623+
}
616624
>
617625
{videoOptionsOpen ? (
618626
<>

src/types/i18n.d.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2010,16 +2010,20 @@ declare module 'I18n/en-US.json' {
20102010
'videoCallMenuMoreRaiseHand': `Raise hand`;
20112011
'videoCallMenuMoreSeeParticipants': `See participants`;
20122012
'videoCallMenuMoreVideoSettings': `Video Settings`;
2013+
'videoCallNoCameraAvailable': `No options`;
20132014
'videoCallOverlayCamera': `Camera`;
20142015
'videoCallOverlayChangeViewMode': `Change view mode`;
20152016
'videoCallOverlayCloseFullScreen': `Go back to minimized view`;
2017+
'videoCallOverlayCloseOptions': `Close options`;
20162018
'videoCallOverlayConversations': `Conversations`;
20172019
'videoCallOverlayFitVideoLabel': `Double-click to view full screen`;
20182020
'videoCallOverlayFitVideoLabelGoBack': `Double-click to show all participants`;
20192021
'videoCallOverlayHangUp': `Hang Up`;
20202022
'videoCallOverlayHideParticipantsList': `Hide participants list`;
20212023
'videoCallOverlayMicrophone': `Microphone`;
2024+
'videoCallOverlayOpenCameraOptions': `Open camera options`;
20222025
'videoCallOverlayOpenFullScreen': `Open the call in full screen`;
2026+
'videoCallOverlayOpenMicrophoneAndSpeakerOptions': `Open microphone and speaker options`;
20232027
'videoCallOverlayOpenPopupWindow': `Open in a new window`;
20242028
'videoCallOverlayParticipantsListCloseButton': `Hide participants`;
20252029
'videoCallOverlayParticipantsListLabel': `Participants ({count})`;
@@ -2048,7 +2052,6 @@ declare module 'I18n/en-US.json' {
20482052
'videoCallbackgroundBlurHeadline': `Background`;
20492053
'videoCallbackgroundNotBlurred': `Don\'t blur my background`;
20502054
'videoCallvideoInputCamera': `Camera`;
2051-
'videoCallNoCameraAvailable': `No options`;
20522055
'videoSpeakersTabAll': `All ({count})`;
20532056
'videoSpeakersTabSpeakers': `Speakers`;
20542057
'viewingInAnotherWindow': `Viewing in another window`;

0 commit comments

Comments
 (0)