1111│ └── app-config/ # Webapp configuration
1212└── server/ # Node.js/Express backend API
1313 └── src/ # Server source code
14+ libraries/ # Shared libraries
15+ └── Logger/ # Unified logging library
1416docs/ # Project documentation
1517package.json # Root dependencies (use yarn commands)
1618```
@@ -44,32 +46,25 @@ Use these exact formats:
4446
4547ALWAYS verify these items in EVERY PR:
4648
47- ✓ Input validation and sanitization
48- ✓ API response validation and error handling
49- ✓ No dangerouslySetInnerHTML without sanitization
50- ✓ No hardcoded secrets, tokens, or API keys
51- ✓ Safe URL handling and redirect validation
52- ✓ Proper authentication and authorization
49+ ✓ Input validation and sanitization ✓ API response validation and error handling ✓ No dangerouslySetInnerHTML without sanitization ✓ No hardcoded secrets, tokens, or API keys ✓ Safe URL handling and redirect validation ✓ Proper authentication and authorization
5350
5451## ACCESSIBILITY CHECKLIST
5552
5653For UI changes in apps/webapp/src/:
5754
58- ✓ Keyboard navigation (Tab, Enter, Space, Escape, Arrow keys)
59- ✓ Focus management (visible focus, proper trapping in modals)
60- ✓ ARIA labels and roles (icon buttons need action-focused labels)
61- ✓ Form accessibility (labels tied to inputs, error descriptions)
62- ✓ Screen reader support (aria-live for dynamic content)
55+ ✓ Keyboard navigation (Tab, Enter, Space, Escape, Arrow keys) ✓ Focus management (visible focus, proper trapping in modals) ✓ ARIA labels and roles (icon buttons need action-focused labels) ✓ Form accessibility (labels tied to inputs, error descriptions) ✓ Screen reader support (aria-live for dynamic content)
6356
6457## REVIEW SCOPE
6558
6659REVIEW these files:
60+
6761- Security: All code changes (especially APIs and user input)
68- - Accessibility: apps/webapp/src/** / *
69- - TypeScript: apps/** / * .{ts,tsx}
70- - React: apps/webapp/src/** / * .{tsx,jsx}
62+ - Accessibility: apps/webapp/src/\* _ / _
63+ - TypeScript: apps/\* _ / _ .{ts,tsx}
64+ - React: apps/webapp/src/\* _ / _ .{tsx,jsx}
7165
7266DO NOT REVIEW:
67+
7368- Code formatting (handled by prettier/eslint)
7469- Import ordering (automated)
7570- Trivial naming preferences
@@ -81,29 +76,34 @@ DO NOT REVIEW:
8176
8277## SPECIALIZED INSTRUCTION FILES
8378
84- - Security: .github/instructions/security.instructions.md (apps/** / * )
85- - Accessibility: .github/instructions/accessibility.instructions.md (apps/webapp/src/** / * )
86- - React: .github/instructions/react.instructions.md (apps/webapp/src/** / * .{tsx,jsx})
87- - TypeScript: .github/instructions/typescript.instructions.md (apps/** / * .{ts,tsx})
79+ - Security: .github/instructions/security.instructions.md (apps/\* _ / _ )
80+ - Accessibility: .github/instructions/accessibility.instructions.md (apps/webapp/src/\* _ / _ )
81+ - React: .github/instructions/react.instructions.md (apps/webapp/src/\* _ / _ .{tsx,jsx})
82+ - TypeScript: .github/instructions/typescript.instructions.md (apps/\* _ / _ .{ts,tsx})
8883
8984## Pull Request Review Process
9085
9186### When Reviewing PRs
87+
9288** Your Approach:**
89+
93901 . Review only the code changes shown in the diff
94912 . Focus on security, accessibility, and critical functionality
95923 . Use clear severity levels in comments
96934 . Provide specific, actionable feedback with code examples when helpful
9794
9895### Comment Guidelines
96+
9997** Format each comment with:**
98+
10099- Severity level: ** [ Blocker] ** , ** [ Important] ** , or ** [ Suggestion] **
101100- File location and line numbers
102101- Clear explanation of the issue
103102- Specific fix suggestion when appropriate
104103
105104** Example:**
106- ```
105+
106+ ````
107107**[Blocker]** - Security vulnerability in authentication.ts:45
108108
109109The password validation logic allows empty strings. This could allow unauthorized access.
@@ -113,7 +113,8 @@ The password validation logic allows empty strings. This could allow unauthorize
113113if (!password || password.trim().length === 0) {
114114 throw new Error('Password cannot be empty');
115115}
116- ```
116+ ````
117+
117118```
118119
119120### Security Review Checklist
@@ -151,3 +152,4 @@ When new dependencies are added:
151152- Any **[Blocker]** issues exist
152153- Critical security vulnerabilities are found
153154- Essential accessibility features are missing
155+ ```
0 commit comments