fix: Revert "fix: prevent session-expired redirect after logout(WPB-20547) (#19605)" (#19671)

This reverts commit 3bbfdd7.

Author: thisisamir98

src/script/main/app.ts

@@ -80,7 +80,7 @@ import {PropertiesService} from 'Repositories/properties/PropertiesService';
 import {SearchRepository} from 'Repositories/search/SearchRepository';
 import {SelfRepository} from 'Repositories/self/SelfRepository';
 import {SelfService} from 'Repositories/self/SelfService';
-import {StorageKey, StorageRepository, StorageService} from 'Repositories/storage';
+import {StorageRepository, StorageService} from 'Repositories/storage';
 import {TeamRepository} from 'Repositories/team/TeamRepository';
 import {TeamService} from 'Repositories/team/TeamService';
 import {EventTrackingRepository} from 'Repositories/tracking/EventTrackingRepository';
@@ -91,7 +91,6 @@ import {DebugUtil} from 'Util/DebugUtil';
 import {Environment} from 'Util/Environment';
 import {t} from 'Util/LocalizerUtil';
 import {getLogger, Logger} from 'Util/Logger';
-import {loadValue, resetStoreValue} from 'Util/StorageUtil';
 import {durationFrom, formatCoarseDuration, TIME_IN_MILLIS} from 'Util/TimeUtil';
 import {AppInitializationStep, checkIndexedDb, InitializationEventLogger} from 'Util/util';
 
@@ -376,7 +375,7 @@ export class App {
    * @param config
    * @param onProgress
    */
-  async initApp(clientType: ClientType, onProgress: (message?: string) => void): Promise<User | undefined> {
+  async initApp(clientType: ClientType, onProgress: (message?: string) => void) {
     // add body information
     const startTime = Date.now();
     await updateApiVersion();
@@ -407,19 +406,6 @@ export class App {
 
       telemetry.timeStep(AppInitTimingsStep.RECEIVED_ACCESS_TOKEN);
 
-      const showLoginAfterLogout = Boolean(loadValue<boolean>(StorageKey.AUTH.SHOW_LOGIN));
-      resetStoreValue(StorageKey.AUTH.SHOW_LOGIN);
-
-      if (showLoginAfterLogout) {
-        const hasAuthenticatedSession = this.apiClient.transport?.http?.hasValidAccessToken?.() ?? false;
-
-        if (!hasAuthenticatedSession) {
-          this.logger.info('User flagged as logged out without an authenticated session. Redirecting to login.');
-          this.repository.lifeCycle.redirectToLogin(SIGN_OUT_REASON.NOT_SIGNED_IN);
-          return undefined;
-        }
-      }
-
       let selfUser: User;
 
       try {

src/script/repositories/LifeCycleRepository/LifeCycleRepository.test.ts

@@ -1,6 +1,6 @@
 /*
  * Wire
- * Copyright (C) 2025 Wire Swiss GmbH
+ * Copyright (C) 2018 Wire Swiss GmbH
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -17,11 +17,6 @@
  *
  */
 
-jest.mock('Util/StorageUtil', () => ({
-  storeValue: jest.fn(),
-  resetStoreValue: jest.fn(),
-}));
-
 import {amplify} from 'amplify';
 
 import {WebAppEvents} from '@wireapp/webapp-events';
@@ -35,7 +30,6 @@ import type {EventRepository} from 'Repositories/event/EventRepository';
 import {StorageKey} from 'Repositories/storage/StorageKey';
 import type {StorageRepository} from 'Repositories/storage/StorageRepository';
 import type {UserRepository} from 'Repositories/user/UserRepository';
-import {storeValue, resetStoreValue} from 'Util/StorageUtil';
 
 import {LifeCycleRepository, doSimpleRedirect, type LifeCycleDependencies} from './LifeCycleRepository';
 
@@ -605,22 +599,6 @@ describe('LifeCycleRepository', () => {
 
       expect(mockDependencies.eventRepository.disconnectWebSocket).toHaveBeenCalled();
     });
-
-    it('sets SHOW_LOGIN flag on USER_REQUESTED logout', async () => {
-      (mockDependencies.clientRepository.isCurrentClientPermanent as jest.Mock).mockReturnValue(true);
-
-      await lifeCycleRepository.logout(SIGN_OUT_REASON.USER_REQUESTED, true);
-
-      expect(storeValue).toHaveBeenCalledWith(StorageKey.AUTH.SHOW_LOGIN, true);
-    });
-
-    it('resets SHOW_LOGIN flag on non USER_REQUESTED logout like SESSION_EXPIRED)', async () => {
-      (mockDependencies.clientRepository.isCurrentClientPermanent as jest.Mock).mockReturnValue(true);
-
-      await lifeCycleRepository.logout(SIGN_OUT_REASON.SESSION_EXPIRED, false);
-
-      expect(resetStoreValue).toHaveBeenCalledWith(StorageKey.AUTH.SHOW_LOGIN);
-    });
   });
 
   describe('state management', () => {

src/script/repositories/LifeCycleRepository/LifeCycleRepository.ts

@@ -30,7 +30,6 @@ import {StorageKey} from 'Repositories/storage/StorageKey';
 import type {StorageRepository} from 'Repositories/storage/StorageRepository';
 import type {UserRepository} from 'Repositories/user/UserRepository';
 import {getLogger, Logger} from 'Util/Logger';
-import {resetStoreValue, storeValue} from 'Util/StorageUtil';
 import {includesString} from 'Util/StringUtil';
 import {appendParameter} from 'Util/UrlUtil';
 
@@ -130,13 +129,6 @@ export class LifeCycleRepository {
     }
     this.isCurrentlyLoggingOut = true;
 
-    const isUserRequestedLogout = signOutReason === SIGN_OUT_REASON.USER_REQUESTED;
-    if (isUserRequestedLogout) {
-      storeValue(StorageKey.AUTH.SHOW_LOGIN, true);
-    } else {
-      resetStoreValue(StorageKey.AUTH.SHOW_LOGIN);
-    }
-
     // Helper function to notify about logout completion and redirect
     const completeLogoutAndRedirect = (): void => {
       this.logger.info(