fix(cli): improve --src path handling, error messaging, and documentation for new command\n\nReferences: #16

Author: flydev-fr

README.md

@@ -34,6 +34,12 @@ Run `wire-cli` followed by the desired command to execute various tasks. For exa
 wire-cli new myproject
 ```
 
+### Path Arguments (e.g., --src)
+- You can use both relative and absolute paths for arguments like `--src`.
+- Paths with spaces should be quoted: `--src="C:/path/with spaces/ProcessWire"`
+- Both forward `/` and backward `\` slashes are supported; they are normalized automatically.
+- If the path does not exist or is not accessible, a clear error message will be shown.
+
 For a complete list of available commands and options, use the `help` command:
 
 ## Documentation

Tests/Commands/Common/NewCommandTest.php

@@ -53,6 +53,58 @@ public function testDownload() {
         $this->assertDirectoryNotExists(Base::INSTALLATION_FOLDER . '/site');
     }
 
+    public function testDownloadWithRelativeSrc() {
+        $this->checkInstallation();
+        $relativePath = basename(Base::INSTALLATION_ARCHIVE); // e.g., 'archive.zip'
+        if (!file_exists($relativePath)) {
+            copy(Base::INSTALLATION_ARCHIVE, $relativePath);
+        }
+        // Ensure the ProcessWire directory exists for the test
+        if (!is_dir(Base::INSTALLATION_FOLDER)) {
+            mkdir(Base::INSTALLATION_FOLDER);
+        }
+        $options = array('--no-install' => true, '--src' => $relativePath);
+        $this->tester->execute(array_merge($this->defaults, $options));
+        $this->assertDirectoryExists(Base::INSTALLATION_FOLDER);
+        if (file_exists($relativePath)) {
+            unlink($relativePath);
+        }
+    }
+
+    public function testDownloadWithAbsoluteSrc() {
+        $this->checkInstallation();
+        $absolutePath = realpath(Base::INSTALLATION_ARCHIVE);
+        // Ensure the ProcessWire directory exists for the test
+        if (!is_dir(Base::INSTALLATION_FOLDER)) {
+            mkdir(Base::INSTALLATION_FOLDER);
+        }
+        $options = array('--no-install' => true, '--src' => $absolutePath);
+        $this->tester->execute(array_merge($this->defaults, $options));
+        $this->assertDirectoryExists(Base::INSTALLATION_FOLDER);
+    }
+
+    public function testDownloadWithNonExistentSrc() {
+        $this->checkInstallation();
+        $options = array('--no-install' => true, '--src' => 'nonexistent.zip');
+        $this->expectException(\RuntimeException::class);
+        $this->tester->execute(array_merge($this->defaults, $options));
+    }
+
+    public function testDownloadWithMixedSlashesAndSpacesSrc() {
+        $this->checkInstallation();
+        $absolutePath = realpath(Base::INSTALLATION_ARCHIVE);
+        // Simulate a path with mixed slashes and spaces
+        $mixedPath = str_replace('/', '\\', $absolutePath);
+        $mixedPath = ' ' . $mixedPath . ' ';
+        // Ensure the ProcessWire directory exists for the test
+        if (!is_dir(Base::INSTALLATION_FOLDER)) {
+            mkdir(Base::INSTALLATION_FOLDER);
+        }
+        $options = array('--no-install' => true, '--src' => $mixedPath);
+        $this->tester->execute(array_merge($this->defaults, $options));
+        $this->assertDirectoryExists(Base::INSTALLATION_FOLDER);
+    }
+
     /**
       * @depends testDownload
       * @expectedException RuntimeException

docs/commands/common.md

@@ -31,12 +31,18 @@ $ wirecli new {directory}*
 --userpass : Admin password
 --useremail : Admin email address
 --profile : Default site profile: `path/to/profile.zip` OR one of `beginner, blank, classic, default, languages`
---src : Path to pre-downloaded folder, zip or tgz: `path/to/src`
+--src : Path to pre-downloaded folder, zip or tgz: `path/to/src` (supports relative/absolute, spaces, and both / and \ slashes)
 --sha : Download specific commit
 --no-install : Disable installation
 --v : Increase the verbosity of messages
 ```
 
+**Note:**
+- Paths for `--src` can be relative or absolute.
+- Paths with spaces should be quoted: `--src="C:/path/with spaces/ProcessWire"`
+- Both `/` and `\` slashes are supported and normalized automatically.
+- If the path does not exist or is not accessible, a clear error message will be shown.
+
 ### Examples
 
 Download and unzip ProcessWires master branch into current directory.

src/Commands/Common/NewCommand.php

@@ -266,11 +266,31 @@ private function ask($name,  $question, $default = null, $hidden = false, $autoc
   /**
    * Get absolute path
    *
-   * @param $path
+   * @param string $path
    * @return string
    */
   private function getAbsolutePath($path) {
-    return $this->fs->isAbsolutePath($path) ? $path : getcwd() . DIRECTORY_SEPARATOR . $path;
+    // Normalize slashes for cross-platform compatibility
+    $normalizedPath = str_replace(['/', '\\'], DIRECTORY_SEPARATOR, $path);
+    // Remove trailing slashes
+    $normalizedPath = rtrim($normalizedPath, DIRECTORY_SEPARATOR);
+    // If path is quoted (e.g., with spaces), remove quotes
+    $normalizedPath = trim($normalizedPath, "'\"");
+    // If not absolute, prepend current working directory
+    $absolutePath = $this->fs->isAbsolutePath($normalizedPath)
+      ? $normalizedPath
+      : getcwd() . DIRECTORY_SEPARATOR . $normalizedPath;
+    // Canonicalize path (resolve .., .)
+    $realPath = realpath($absolutePath);
+    if ($realPath === false) {
+      throw new \RuntimeException(
+        sprintf(
+          "The provided --src path '%s' does not exist or is not accessible. Please check the path and try again.",
+          $path
+        )
+      );
+    }
+    return $realPath;
   }
 
   /**