we are getting TypeError: Cannot read property 'path' of undefined when the URL is not exist (status code is 404)

[ha-akelius]

we are getting TypeError: Cannot read property 'path' of undefined when the URL is not exist (status code is 404)
from console the error is coming from this file

node_modules/prometheus-api-metrics/src/koa-middleware.js:98
let route = properRoute.path; // properRoute is undefined for 404 request

is there a way to fix it?

[pedrolaxe]

I add this verification inside koa-middleware.js on this function _findFirstProperRoute
if (!route.path.endsWith('(.*)') || route.path != "/" ) { return route; }

Now its working! @wirehead

[wirehead]

Looking..

[pedrolaxe]

But not showing the correct 404 route on prometheus, shows:
route="/(.*)"

[wirehead]

I added a temporary workaround and pushed v0,0.3. On my end, it'll prevent any 404 routes from being recorded.

I think this issue is probably undesired behavior on the upstream library and wrote up an isolated test case for PayU/prometheus-api-metrics#59.

[pedrolaxe]

I added a temporary workaround and pushed v0,0.3. On my end, it'll prevent any 404 routes from being recorded.

I think this issue is probably undesired behavior on the upstream library and wrote up an isolated test case for PayU/prometheus-api-metrics#59.

Okay, let's wait ..

[pedrolaxe]

I Update to v0.0.3, but now not looking for any metrics route ...

ex:
http_request_size_bytes_count