Skip to content

Commit c304c06

Browse files
Merge pull request #99 from hassomehide/fix-create-mapping-response
Change the return type of create_mapping from MappingResponse to Mapping
2 parents 20442b2 + 3ebdd32 commit c304c06

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

tests/test_resources/test_mapping/test_mapping_resource.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,24 @@
1616
@pytest.mark.resource
1717
@responses.activate
1818
def test_create_mapping():
19-
e = MappingResponse(body="test", status=200)
20-
resp = e.get_json_data()
21-
responses.add(
22-
responses.POST, "http://localhost/__admin/mappings", json=resp, status=200
23-
)
24-
2519
m = Mapping(
2620
priority=1,
2721
request=MappingRequest(url="test", method="GET"),
2822
response=MappingResponse(status=200, body="test"),
2923
)
3024

25+
e = Mapping(**m, id="1234-5678")
26+
resp = e.get_json_data()
27+
responses.add(
28+
responses.POST, "http://localhost/__admin/mappings", json=resp, status=200
29+
)
30+
3131
r = Mappings.create_mapping(m)
32-
assert isinstance(r, MappingResponse)
33-
assert r.status == 200
34-
assert r.body == "test"
32+
assert isinstance(r, Mapping)
33+
assert r.id == "1234-5678"
34+
assert r.priority == 1
35+
assert r.request == m.request
36+
assert r.response == m.response
3537

3638

3739
@pytest.mark.unit

wiremock/resources/mappings/resource.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def create_mapping(cls, mapping, parameters={}):
3030
params=parameters,
3131
)
3232
response = cls.REST_CLIENT.handle_response(response)
33-
return MappingResponse.from_dict(response.json())
33+
return Mapping.from_dict(response.json())
3434

3535
@classmethod
3636
def retrieve_all_mappings(cls, parameters={}):

0 commit comments

Comments
 (0)