update changelog, fix test

= · = · commit c256d5b0b958 · 2024-10-16T13:01:30.000+09:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,6 @@
 # Changelog (2024)
+- 2.3.5 (Oct 16)
+  - Fix apigen to use ToT from github for downloading json files. Update to latest protocol 
 - 2.3.4 (Mar 18)
   - Fix return types for calls that return two-dimensional arrays 
 - 2.3.3 (Jan 31)
diff --git a/v2/gcd_test.go b/v2/gcd_test.go
@@ -62,10 +62,6 @@ func testCleanUp() {
 }
 
 func TestDeleteProfileOnExit(t *testing.T) {
-	if runtime.GOOS == "windows" {
-		//t.Skip("windows will hold on to the process handle too long")
-	}
-
 	debugger := NewChromeDebugger(WithDeleteProfileOnExit(),
 		WithFlags([]string{"--headless"}),
 	)
@@ -75,6 +71,9 @@ func TestDeleteProfileOnExit(t *testing.T) {
 	if err != nil {
 		t.Fatalf("error starting chrome: %s\n", err)
 	}
+
+	debugger.NewTab()
+
 	debugger.ExitProcess()
 	time.Sleep(3 * time.Second)
 	if stat, err := os.Stat(profileDir); err == nil {

Original file line number	Diff line number	Diff line change
`@@ -62,10 +62,6 @@ func testCleanUp() {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`func TestDeleteProfileOnExit(t *testing.T) {`
`65`		`- if runtime.GOOS == "windows" {`
`66`		`- //t.Skip("windows will hold on to the process handle too long")`
`67`		`- }`
`68`		`-`
`69`	`65`	`debugger := NewChromeDebugger(WithDeleteProfileOnExit(),`
`70`	`66`	`WithFlags([]string{"--headless"}),`
`71`	`67`	`)`
`@@ -75,6 +71,9 @@ func TestDeleteProfileOnExit(t *testing.T) {`
`75`	`71`	`if err != nil {`
`76`	`72`	`t.Fatalf("error starting chrome: %s\n", err)`
`77`	`73`	`}`
	`74`	`+`
	`75`	`+ debugger.NewTab()`
	`76`	`+`
`78`	`77`	`debugger.ExitProcess()`
`79`	`78`	`time.Sleep(3 * time.Second)`
`80`	`79`	`if stat, err := os.Stat(profileDir); err == nil {`