adding no-op error

dr4hcu5-jan · dr4hcu5-jan · commit 4320afa4d782 · 2024-12-17T12:56:36.000+01:00
diff --git a/internal/jwt/errors.go b/internal/jwt/errors.go
@@ -132,3 +132,5 @@ var ErrForbidden = types.ServiceError{
 	Title:  "Access Forbidden",
 	Detail: "You don't have the required permissions to access this resource",
 }
+
+var ErrNoOp = types.ServiceError{}
diff --git a/internal/jwt/validator.go b/internal/jwt/validator.go
@@ -187,7 +187,7 @@ func (v *Validator) ParseHTTPRequest(r *http.Request) (accessToken jwt.Token, re
 		return nil, &ErrJWTInvalidIssuer
 	case jws.IsVerificationError(err):
 		if v.IsOptional() {
-			return nil, nil
+			return nil, &ErrNoOp
 		}
 		panic("unable to verify jwt")
 	case errors.Is(err, jwt.ErrInvalidJWT()):

Original file line number	Diff line number	Diff line change
`@@ -132,3 +132,5 @@ var ErrForbidden = types.ServiceError{`
`132`	`132`	`Title: "Access Forbidden",`
`133`	`133`	`Detail: "You don't have the required permissions to access this resource",`
`134`	`134`	`}`
	`135`	`+`
	`136`	`+var ErrNoOp = types.ServiceError{}`
Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ func (v Validator) ParseHTTPRequest(r http.Request) (accessToken jwt.Token, re`
`187`	`187`	`return nil, &ErrJWTInvalidIssuer`
`188`	`188`	`case jws.IsVerificationError(err):`
`189`	`189`	`if v.IsOptional() {`
`190`		`- return nil, nil`
	`190`	`+ return nil, &ErrNoOp`
`191`	`191`	`}`
`192`	`192`	`panic("unable to verify jwt")`
`193`	`193`	`case errors.Is(err, jwt.ErrInvalidJWT()):`